Skip to content

Next#161

Merged
markteekman merged 2 commits into
mainfrom
next
Sep 15, 2025
Merged

Next#161
markteekman merged 2 commits into
mainfrom
next

Conversation

@markteekman
Copy link
Copy Markdown
Member

@markteekman markteekman commented Sep 15, 2025

Summary by CodeRabbit

  • New Features

    • None.
  • Style

    • Removed legacy button component styles, including color variants, icon sizing, and hover/focus animations. Buttons that previously used these styles may now inherit default or theme-wide styles, resulting in visual changes.
  • Chores

    • Bumped app version to 4.2.1.
    • Updated accessible component dependency to the latest patch version for compatibility and maintenance.

…le-astro-components package now provides a Button component
…stro-components to version 5.0.1 for improved functionality
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 15, 2025

Deploy Preview for accessible-astro-starter-incluud ready!

Name Link
🔨 Latest commit 47a30f6
🔍 Latest deploy log https://app.netlify.com/projects/accessible-astro-starter-incluud/deploys/68c85b7e0e892700088cebaa
😎 Deploy Preview https://deploy-preview-161--accessible-astro-starter-incluud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 15, 2025

Walkthrough

Removes the SCSS partial defining .button styles and drops its import from the main stylesheet. Updates package.json: bumps the package version and the accessible-astro-components dependency. No other files or APIs are changed.

Changes

Cohort / File(s) Change Summary
Styles — Button removal
src/assets/scss/base/_button.scss, src/assets/scss/index.scss
Deleted _button.scss (removed .button, variants, hover/focus, [data-icon] rules) and removed @use 'base/button' from index.scss.
Package metadata
package.json
Bumped version 4.2.0 → 4.2.1 and updated accessible-astro-components ^5.0.0 → ^5.0.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Next #150 — Also updates package.json with version bump and accessible-astro-components dependency change, overlapping the same metadata.

Poem

I nibbled on styles, a tidy delight,
The buttons hopped off into the night.
A patch, a bump—version carrots in tow,
Dependencies fresh, ready to grow.
With lighter paws I bound through the scene—
ship it, ship it, sleek and clean! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The provided title "Next" is too vague to convey the primary changes in this PR. The changeset removes the base button SCSS partial (dropping the .button selector and its variants) and also bumps package.json and updates accessible-astro-components, none of which are described by "Next". Because the title does not summarize the main change or intent, it does not meet the clarity requirement. Please replace the title with a concise, descriptive sentence that highlights the main change; for example "Remove base .button SCSS and bump version to 4.2.1" or "Remove button styles and update accessible-astro-components to ^5.0.1". If this PR is a merge of multiple unrelated items, pick a title that summarizes the dominant change and expand the PR description with the rest. A clearer title will help reviewers understand the intent at a glance.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch next

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e24075f and 47a30f6.

📒 Files selected for processing (3)
  • package.json (2 hunks)
  • src/assets/scss/base/_button.scss (0 hunks)
  • src/assets/scss/index.scss (0 hunks)
💤 Files with no reviewable changes (2)
  • src/assets/scss/index.scss
  • src/assets/scss/base/_button.scss
🔇 Additional comments (1)
package.json (1)

65-65: Dep bump to accessible-astro-components ^5.0.1 — verify peerDeps & CSS fallout

  • Repo still uses .button (src/pages/accessible-components.astro:427,428,437). Confirm whether v5 removed/renamed that style and update those templates to the package's new classes or add fallback CSS.
  • Verify v5 peerDependencies (Astro/Tailwind versions) against this repo and run a quick local/visual regression smoke test.

Comment thread package.json
"name": "accessible-astro-starter",
"description": "An Accessible Starter Theme for Astro including several accessibility features and tools to help you build faster.",
"version": "4.2.0",
"version": "4.2.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Patch version bump LGTM; please finalize release hygiene.

Looks good for 4.2.1. Before merge, ensure changelog entry, tag, and lockfile updates are included.

Run to verify basics:


🏁 Script executed:

#!/bin/bash
# Changelog has an entry for 4.2.1?
fd -HI '^CHANGELOG\.md$' -t f | xargs -r grep -n '4\.2\.1' || echo "Missing CHANGELOG entry for 4.2.1"

# Any lockfile present?
fd -HI '^(pnpm-lock\.yaml|package-lock\.json|yarn\.lock)$' -t f || echo "No lockfile found"

# Repo version echo (sanity)
jq -r .version package.json

Length of output: 5


🏁 Script executed:

#!/bin/bash
set -uo pipefail

echo "PWD: $(pwd)"
echo
echo "---- find CHANGELOG.md ----"
fd -HI '^CHANGELOG\.md$' -t f -x sh -c 'echo "FILE: {}"; sed -n "1,200p" {}' || echo "No CHANGELOG.md found"

echo
echo "---- search repo for '4.2.1' ----"
rg -n --hidden -uuu --glob '!**/node_modules/**' '4\.2\.1' || echo "NO_MATCHES"

echo
echo "---- check common changelog candidates ----"
for f in CHANGELOG.md CHANGES.md HISTORY.md RELEASE_NOTES.md docs/CHANGELOG.md; do
  if [ -f "$f" ]; then
    echo "FOUND $f"
    rg -n '4\.2\.1' "$f" || echo "NO_ENTRY_IN_$f"
  else
    echo "MISSING $f"
  fi
done

echo
echo "---- lockfiles ----"
for f in pnpm-lock.yaml package-lock.json yarn.lock npm-shrinkwrap.json; do
  if [ -f "$f" ]; then
    echo "FOUND $f"
    stat -c '%n %s %y' "$f" || true
    echo "HEAD (first 5 lines):"
    head -n 5 "$f" || true
  else
    echo "MISSING $f"
  fi
done

echo
echo "---- git tags matching 4.2.1 ----"
git tag -l 'v4.2.1' || true
git tag -l '4.2.1' || true

echo
echo "---- package.json version ----"
jq -r .version package.json || true

Length of output: 591


Release blocked — add CHANGELOG entry, commit lockfile, and create tag v4.2.1.

  • package.json version: 4.2.1.
  • No changelog found or 4.2.1 entry present (no CHANGELOG.md / CHANGES.md / HISTORY.md / RELEASE_NOTES.md).
  • No lockfile present (pnpm-lock.yaml, package-lock.json, yarn.lock, npm-shrinkwrap.json).
  • No git tag 'v4.2.1' or '4.2.1' exists.
🤖 Prompt for AI Agents
package.json lines 4-4: release is blocked because version 4.2.1 was bumped
without a changelog entry, a committed lockfile, or a git tag; fix by adding a
human-readable entry for 4.2.1 to the repository changelog (create CHANGELOG.md
if missing) describing the release changes, generate and commit the appropriate
package manager lockfile (pnpm-lock.yaml, package-lock.json, or yarn.lock) into
git, and create & push a git tag named v4.2.1 (and optionally v4.2.1 annotated)
pointing at the release commit.

@markteekman markteekman merged commit e24994e into main Sep 15, 2025
5 checks passed
@markteekman markteekman deleted the next branch January 6, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant