-
-
Notifications
You must be signed in to change notification settings - Fork 205
Feature/ux improvements #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ea819d0
a4f9343
1f385de
900ecac
c58aa40
23b1e12
a095b51
1e3463b
08967e3
a486e13
a931f90
15aa47a
1d98b06
e30ebd6
142af72
1f0eb38
9602405
eb0d2a6
72ab4ff
5366dbc
486bed3
e0bab31
0cdcac7
e6b08a4
c962e3d
1b4b0ab
2b74bfe
eb36c6f
29354c5
0f65453
02ffb3f
76d552d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,4 +27,7 @@ yarn-error.log* | |
| package-lock.json | ||
|
|
||
| # astro build files | ||
| .astro | ||
| .astro | ||
|
|
||
| # cursor rules | ||
| .cursor/rules | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "name": "accessible-astro-starter", | ||
| "description": "An Accessible Starter Theme for Astro including several accessibility features and tools to help you build faster.", | ||
| "version": "3.4.1", | ||
| "version": "4.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainMajor version upgrade requires thorough testing The version bump to 4.0.0 indicates breaking changes in the application, which aligns with the extensive architectural changes mentioned in the PR description. 🏁 Script executed: #!/bin/bash
# Check if there's a CHANGELOG.md file documenting the breaking changes
if [ -f "CHANGELOG.md" ]; then
echo "CHANGELOG.md exists. Checking for version 4.0.0 entries:"
grep -A 15 "4.0.0" CHANGELOG.md
else
echo "No CHANGELOG.md found. Consider adding one to document breaking changes."
fiLength of output: 180 Major version bump to 4.0.0 – document breaking changes and test thoroughly No CHANGELOG.md was found to capture the breaking changes introduced in v4.0.0. To ensure proper team onboarding and future maintenance, please:
Thoroughly test the application against these changes before merging. |
||
| "author": "Incluud", | ||
| "license": "MIT", | ||
| "homepage": "https://accessible-astro.netlify.app/", | ||
|
|
@@ -22,7 +22,8 @@ | |
| "responsive", | ||
| "ui-library", | ||
| "ui-components", | ||
| "blog" | ||
| "blog", | ||
| "portfolio" | ||
| ], | ||
| "repository": { | ||
| "type": "git", | ||
|
|
@@ -32,28 +33,28 @@ | |
| "url": "https://github.com/incluud/accessible-astro-starter/issues" | ||
| }, | ||
| "devDependencies": { | ||
| "@astrojs/mdx": "^4.0.8", | ||
| "@astrojs/partytown": "^2.1.3", | ||
| "@astrojs/tailwind": "^6.0.0", | ||
| "@iconify-json/ion": "^1.2.1", | ||
| "@iconify-json/mdi": "^1.2.1", | ||
| "@typescript-eslint/eslint-plugin": "^6.21.0", | ||
| "@typescript-eslint/parser": "^6.21.0", | ||
| "astro": "^5.3.0", | ||
| "astro-compress": "^2.3.5", | ||
| "astro-icon": "^1.1.4", | ||
| "eslint": "^8.57.0", | ||
| "eslint-plugin-astro": "^0.31.4", | ||
| "@astrojs/mdx": "^4.2.5", | ||
| "@astrojs/partytown": "^2.1.4", | ||
| "@iconify-json/lucide": "^1.2.39", | ||
| "@typescript-eslint/eslint-plugin": "^8.31.0", | ||
| "@typescript-eslint/parser": "^8.31.0", | ||
| "astro": "^5.7.5", | ||
| "astro-compress": "^2.3.8", | ||
| "astro-icon": "^1.1.5", | ||
| "eslint": "^9.0.0", | ||
| "eslint-plugin-astro": "^1.3.1", | ||
| "eslint-plugin-jsx-a11y": "^6.10.2", | ||
| "prettier": "^3.4.1", | ||
| "prettier": "^3.5.3", | ||
| "prettier-plugin-astro": "^0.14.1", | ||
| "prettier-plugin-css-order": "^2.1.2", | ||
| "prettier-plugin-tailwindcss": "^0.6.9", | ||
| "sass": "^1.81.0", | ||
| "prettier-plugin-tailwindcss": "^0.6.11", | ||
| "sanitize-html": "^2.16.0", | ||
| "sass": "^1.87.0", | ||
| "svgo": "^3.3.2", | ||
| "tailwindcss": "^3.4.15" | ||
| "tailwindcss": "^4.1.4" | ||
| }, | ||
| "dependencies": { | ||
| "accessible-astro-components": "^4.1.0" | ||
| "@tailwindcss/vite": "^4.1.4", | ||
| "accessible-astro-components": "^4.1.1" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| Copyright (c) 2020, Braille Institute of America, Inc. (https://www.brailleinstitute.org/), | ||
| with Reserved Font Names: "ATKINSON" and "HYPERLEGIBLE". | ||
|
|
||
| This Font Software is licensed under the SIL Open Font License, Version 1.1. | ||
| This license is copied below, and is also available with a FAQ at: | ||
| https://openfontlicense.org | ||
|
|
||
|
|
||
| ----------------------------------------------------------- | ||
| SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007 | ||
| ----------------------------------------------------------- | ||
|
|
||
| PREAMBLE | ||
| The goals of the Open Font License (OFL) are to stimulate worldwide | ||
| development of collaborative font projects, to support the font creation | ||
| efforts of academic and linguistic communities, and to provide a free and | ||
| open framework in which fonts may be shared and improved in partnership | ||
| with others. | ||
|
|
||
| The OFL allows the licensed fonts to be used, studied, modified and | ||
| redistributed freely as long as they are not sold by themselves. The | ||
| fonts, including any derivative works, can be bundled, embedded, | ||
| redistributed and/or sold with any software provided that any reserved | ||
| names are not used by derivative works. The fonts and derivatives, | ||
| however, cannot be released under any other type of license. The | ||
| requirement for fonts to remain under this license does not apply | ||
| to any document created using the fonts or their derivatives. | ||
|
|
||
| DEFINITIONS | ||
| "Font Software" refers to the set of files released by the Copyright | ||
| Holder under this license and clearly marked as such. This may | ||
| include source files, build scripts and documentation. | ||
|
|
||
| "Reserved Font Names" refers to any names specified as such after the | ||
| copyright statement. | ||
|
|
||
| "Original Version" refers to the collection of Font Software components as | ||
| distributed by the Copyright Holder. | ||
|
|
||
| "Modified Version" refers to any derivative made by adding to, deleting, | ||
| or substituting -- in part or in whole -- any of the components of the | ||
| Original Version, by changing formats or by porting the Font Software to a | ||
| new environment. | ||
|
|
||
| "Author" refers to any designer, engineer, programmer, technical writer or other | ||
| person who contributed to the Font Software. | ||
|
|
||
| PERMISSION & CONDITIONS | ||
| VP/#68933639.2 | ||
| Permission is hereby granted, free of charge, to any person obtaining a copy of the Font | ||
| Software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and | ||
| unmodified copies of the Font Software, subject to the following conditions: | ||
|
|
||
| 1) Neither the Font Software nor any of its individual components, in Original or | ||
| Modified Versions, may be sold by itself. | ||
|
|
||
| 2) Original or Modified Versions of the Font Software may be bundled, redistributed | ||
| and/or sold with any software, provided that each copy contains the above copyright | ||
| notice and this license. These can be included either as stand-alone text files, human- | ||
| readable headers or in the appropriate machine-readable metadata fields within text or | ||
| binary files as long as those fields can be easily viewed by the user. | ||
|
|
||
| 3) No Modified Version of the Font Software may use the Reserved Font Names unless | ||
| explicit written permission is granted by the Copyright Holder. This restriction only | ||
| applies to the primary font name as presented to the users. | ||
|
|
||
| 4) The name of the Copyright Holder or the Author(s) of the Font Software shall not be | ||
| used to promote, endorse or advertise any Modified Version, except to acknowledge the | ||
| contributions of the Copyright Holder and the Author(s) or with their explicit written | ||
| permission. | ||
|
|
||
| 5) The Font Software, modified or unmodified, in part or in whole, must be distributed | ||
| entirely under this license, and must not be distributed under any other license. The | ||
| requirement for fonts to remain under this license does not apply to any document | ||
| created using the Font Software. | ||
|
|
||
| TERMINATION | ||
| This license becomes null and void if any of the above conditions are not met. | ||
|
|
||
| DISCLAIMER | ||
| THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
| EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF | ||
| MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
| NONINFRINGEMENT OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO | ||
| EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR | ||
| OTHER LIABILITY, INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR | ||
| CONSEQUENTIAL DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| OTHERWISE, ARISING FROM, OUT OF THE USE OR INABILITY TO USE THE FONT | ||
| SOFTWARE OR FROM OTHER DEALINGS IN THE FONT SOFTWARE. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,23 @@ | ||
| @use 'sass:map'; | ||
|
|
||
| // | ------------------------------------------------------------- | ||
| // | Breakpoint | ||
| // | ------------------------------------------------------------- | ||
|
|
||
| $breakpoints: ( | ||
| 'default': 0, | ||
| 'small': 24em, | ||
| 'medium': 48em, | ||
| 'large': 75em, | ||
| 'xs': 320px, | ||
| 's': 480px, | ||
| 'm': 768px, | ||
| 'l': 1024px, | ||
| 'xl': 1280px, | ||
| '2xl': 1536px, | ||
| ) !default; | ||
|
|
||
| @mixin breakpoint($breakpoint) { | ||
| @if map.has-key($breakpoints, $breakpoint) { | ||
| @media (min-width: map.get($breakpoints, $breakpoint)) { | ||
| @if map-has-key($breakpoints, $breakpoint) { | ||
| @media (min-width: map-get($breakpoints, $breakpoint)) { | ||
| @content; | ||
| } | ||
| } @else if (type_of($breakpoint) == number) { | ||
| @media (min-width: $breakpoint+'px') { | ||
| @media (min-width: #{$breakpoint}px) { | ||
| @content; | ||
| } | ||
| } @else { | ||
| @error "Not a correct value, check _base-breakpoints for available values."; | ||
| @error "Not a correct value"; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ensure path aliases are synchronized with TypeScript configuration
The path aliases defined here need to be synchronized with your tsconfig.json to ensure proper IDE support and TypeScript compilation.
🏁 Script executed:
Length of output: 694
Sync path aliases in tsconfig.json with astro.config.mjs
tsconfig.json currently only defines aliases for
@components,@layouts, and@assets. You should add the remaining aliases from astro.config.mjs to ensure IDE support and correct TS compilation.Points of attention:
"paths"mappingSuggested diff:
"paths": { - "@components/*": ["src/components/*"], - "@layouts/*": ["src/layouts/*"], - "@assets/*": ["src/assets/*"] + "@components/*": ["src/components/*"], + "@layouts/*": ["src/layouts/*"], + "@assets/*": ["src/assets/*"], + "@content/*": ["src/content/*"], + "@pages/*": ["src/pages/*"], + "@public/*": ["public/*"], + "@post-images/*": ["public/posts/*"], + "@project-images/*": ["public/projects/*"] }After updating, restart your TS server/IDE to pick up the new mappings.
📝 Committable suggestion