Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing guide (resolves #182) #185

Merged
merged 8 commits into from
Apr 9, 2020
Merged

Conversation

greatislander
Copy link
Member

  • This pull request has been linted by running npm run lint without errors
  • This pull request has been tested by running npm run dev and reviewing affected routes
  • This pull request has been built by running npm run generate without errors
  • This isn't a duplicate of an existing pull request

Description

Expands README to include contributing instructions.

Related issues

@greatislander greatislander added the documentation Improvements or additions to documentation label Apr 8, 2020
@greatislander greatislander added this to the 1.1.0 milestone Apr 8, 2020
@greatislander greatislander self-assigned this Apr 8, 2020
@cindyli
Copy link
Contributor

cindyli commented Apr 8, 2020

@jobara's input on this pull request would be valuable. He's experienced dealing with with licensing, readme languages etc.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@jobara jobara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm struggling a bit with the dev content in the README vs the CONTRIBUTING file, but can't quite put my finger on it. I get the feeling like I need to go back and forth between the two documents. Maybe that's okay, but not sure. If you can think of any further ways to improve this, please add them otherwise I guess we can leave it for later.

Regarding the "release" tool. I believe it saves the release info straight to GitHub.

  1. can we automate this with GitHub Actions. I suppose we might have to do some determining of the type of release if there isn't an API for that.
  2. if we don't use GitHub actions, do we want to include this info in the readme or a change log that's stored in the repo and included in the tag

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@greatislander
Copy link
Member Author

I'm struggling a bit with the dev content in the README vs the CONTRIBUTING file, but can't quite put my finger on it. I get the feeling like I need to go back and forth between the two documents. Maybe that's okay, but not sure. If you can think of any further ways to improve this, please add them otherwise I guess we can leave it for later.

My differentiation strategy is: technical guide in README, process guide in CONTRIBUTING. We can always adjust/improve later though, as you say.

Regarding the "release" tool. I believe it saves the release info straight to GitHub.

When you run release, it:

  • bumps the version based on the semantic versioning strategy (patch, minor, or major)
  • provides an interactive prompt which walks you through each commit since the last tag to build a changelog
  • commits, tags, and pushes the new version to GitHub
  • opens a draft GitHub release with the generated changelog (example)
1. can we automate this with GitHub Actions. I suppose we might have to do some determining of the type of release if there isn't an API for that.

Yes, this is definitely something we can explore but feels low priority at the moment.

2. if we don't use GitHub actions, do we want to include this info in the readme or a change log that's stored in the repo and included in the tag

I think the GitHub release notes are sufficient but we can look into storing them in a changelog as well, but I'm happy with the approach that is in place right now.

@jobara
Copy link
Member

jobara commented Apr 9, 2020

I think the GitHub release notes are sufficient but we can look into storing them in a changelog as well, but I'm happy with the approach that is in place right now.

There's an issue related to this filed against release. Adding here for reference.

@jobara
Copy link
Member

jobara commented Apr 9, 2020

I couldn't figure out a way to test the release scripts, but they looked correct. On the bright side, if they don't work, I guess it won't publish the release. So the risk seems minimal.

jobara
jobara previously requested changes Apr 9, 2020
package.json Show resolved Hide resolved
@greatislander greatislander merged commit 6684953 into dev Apr 9, 2020
@greatislander greatislander deleted the add/documentation branch April 9, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contributor guide
4 participants