-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add contributing guide (resolves #182) #185
Conversation
@jobara's input on this pull request would be valuable. He's experienced dealing with with licensing, readme languages etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling a bit with the dev content in the README vs the CONTRIBUTING file, but can't quite put my finger on it. I get the feeling like I need to go back and forth between the two documents. Maybe that's okay, but not sure. If you can think of any further ways to improve this, please add them otherwise I guess we can leave it for later.
Regarding the "release" tool. I believe it saves the release info straight to GitHub.
- can we automate this with GitHub Actions. I suppose we might have to do some determining of the type of release if there isn't an API for that.
- if we don't use GitHub actions, do we want to include this info in the readme or a change log that's stored in the repo and included in the tag
My differentiation strategy is: technical guide in README, process guide in CONTRIBUTING. We can always adjust/improve later though, as you say.
When you run release, it:
Yes, this is definitely something we can explore but feels low priority at the moment.
I think the GitHub release notes are sufficient but we can look into storing them in a changelog as well, but I'm happy with the approach that is in place right now. |
There's an issue related to this filed against release. Adding here for reference. |
I couldn't figure out a way to test the release scripts, but they looked correct. On the bright side, if they don't work, I guess it won't publish the release. So the risk seems minimal. |
npm run lint
without errorsnpm run dev
and reviewing affected routesnpm run generate
without errorsDescription
Expands README to include contributing instructions.
Related issues