Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ocaml_version for coq:dev CI to run. Closes #23 #24

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

k4rtik
Copy link
Member

@k4rtik k4rtik commented Jun 8, 2022

No description provided.

@k4rtik
Copy link
Member Author

k4rtik commented Jun 8, 2022

So it seems that 8.12 image is not available with 4.12-flambda and dev is not available with 4.07-flambda. To obtain clean CI run, we should consider dropping 8.12, which is almost two years old now.

Generally, in providing these images, they provide support for "The last two compatible OCaml versions", see https://github.com/coq-community/docker-coq/wiki#supported-tags

@khieta thoughts? I am making this change to let the CI run.

incompatible with OCaml v4.12
@k4rtik k4rtik linked an issue Jun 8, 2022 that may be closed by this pull request
@k4rtik k4rtik changed the title Add additional ocaml_version for. coq:dev to close #23 Update ocaml_version for coq:dev CI to run. Closes #23 Jun 8, 2022
@k4rtik
Copy link
Member Author

k4rtik commented Jun 8, 2022

If this change feels good, please feel free to merge.

@khieta
Copy link
Member

khieta commented Jun 8, 2022

Thanks for looking at this @k4rtik!

https://github.com/coq-community/docker-coq/wiki#supported-tags says that they'll build each version of Coq with "OCaml 4.07.1+flambda, which has been widely tested (see e.g. this post) and is compatible with each Coq since 8.7". Is that no longer accurate?

@k4rtik
Copy link
Member Author

k4rtik commented Jun 8, 2022

@khieta clearly not, since dev doesn't have those images anymore. It also doesn't make sense in the long-term as Coq will ultimately drop support for older OCaml versions (though currently, the minimum version is 4.05, which is unoptimized and slower). The wiki page was last updated on Dec 9, 2021.

@k4rtik
Copy link
Member Author

k4rtik commented Jun 8, 2022

I made a post at https://coq.discourse.group/t/install-notes-on-ocaml-versions-and-coq-configuration/713/21?u=kartik so that someone provides updated guidance on which version to use.

@khieta
Copy link
Member

khieta commented Jun 8, 2022

Sounds good. Can we use a different version of OCaml for 8.12 only? I'd like to still test 8.12 since our proofs should work for it.

@k4rtik
Copy link
Member Author

k4rtik commented Jun 8, 2022

It should be possible, but I was not able to figure it out last night. I will wait for some response to my post on Coq Discourse.

@khieta khieta merged commit 955ef79 into main Jun 21, 2022
@khieta khieta deleted the coq-dev-4.12-flambda branch June 21, 2022 14:47
@khieta khieta restored the coq-dev-4.12-flambda branch June 21, 2022 14:51
@k4rtik
Copy link
Member Author

k4rtik commented Jun 21, 2022

Hi @khieta what's the summary here now? I am somewhat confused after not looking at this for two weeks.

In my reading, it seems from their available images and updated OCaml version policy we might be better off using 4.13*-flambda for maximum compatibility.

@k4rtik k4rtik deleted the coq-dev-4.12-flambda branch June 21, 2022 15:57
@khieta
Copy link
Member

khieta commented Jun 21, 2022

@k4rtik I merged your original PR this morning, but found that it didn't build. I guess they switched from 4.12-flambda to 4.13-flambda. My latest PR works, but I'd like to see if I can figure out how to run different versions of OCaml for different versions of Coq. It looks like they don't guarantee that 4.13-flambda will work in the future for Coq versions < 8.16.

@k4rtik
Copy link
Member Author

k4rtik commented Jun 21, 2022

Oh, you were already doing it. I didn't see the PR #25

It looks like they don't guarantee that 4.13-flambda will work in the future for Coq versions < 8.16.

I don't think we can solve this problem once and for all. It will require updating versions in our yml file over time until we decide to stop maintaining (that's just the nature of maintenance).

I think we can stick to their "default" version for our CI.

OCaml 4.13.1+flambda (the "default" version for Coq ≥ 8.16)

ie, when that gets updated, we update the yml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev CI compilation fails, despite code compiling everywhere else
2 participants