-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ocaml_version
for coq:dev CI to run. Closes #23
#24
Conversation
So it seems that Generally, in providing these images, they provide support for "The last two compatible OCaml versions", see https://github.com/coq-community/docker-coq/wiki#supported-tags @khieta thoughts? I am making this change to let the CI run. |
incompatible with OCaml v4.12
ocaml_version
for coq:dev CI to run. Closes #23
If this change feels good, please feel free to merge. |
Thanks for looking at this @k4rtik! https://github.com/coq-community/docker-coq/wiki#supported-tags says that they'll build each version of Coq with "OCaml 4.07.1+flambda, which has been widely tested (see e.g. this post) and is compatible with each Coq since 8.7". Is that no longer accurate? |
@khieta clearly not, since |
I made a post at https://coq.discourse.group/t/install-notes-on-ocaml-versions-and-coq-configuration/713/21?u=kartik so that someone provides updated guidance on which version to use. |
Sounds good. Can we use a different version of OCaml for 8.12 only? I'd like to still test 8.12 since our proofs should work for it. |
It should be possible, but I was not able to figure it out last night. I will wait for some response to my post on Coq Discourse. |
Hi @khieta what's the summary here now? I am somewhat confused after not looking at this for two weeks. In my reading, it seems from their available images and updated OCaml version policy we might be better off using |
@k4rtik I merged your original PR this morning, but found that it didn't build. I guess they switched from 4.12-flambda to 4.13-flambda. My latest PR works, but I'd like to see if I can figure out how to run different versions of OCaml for different versions of Coq. It looks like they don't guarantee that 4.13-flambda will work in the future for Coq versions < 8.16. |
Oh, you were already doing it. I didn't see the PR #25
I don't think we can solve this problem once and for all. It will require updating versions in our I think we can stick to their "default" version for our CI.
ie, when that gets updated, we update the |
No description provided.