Fix handling of symlinks in artifact recording #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasaky
requested review from
shibumi and
pxp928
and removed request for
shibumi
adityasaky
force-pushed
the
symlink-fixes
branch
from
0e1f301
to
3f48de4
Compare
* Records source path instead of destination path for symlinks * Adds explicit parameter to decide if symlinks to directories must be followed Signed-off-by: Aditya Sirish <[email protected]>
adityasaky
force-pushed
the
symlink-fixes
branch
from
3f48de4
to
0f369b6
Compare
|
Thanks for the review! |
This was referenced Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya Sirish [email protected]
Fixes issue:
Related to #57, partially #191
Description:
Please verify and check that the pull request fulfills the following
requirements: