-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add signed releases #128
base: master
Are you sure you want to change the base?
add signed releases #128
Conversation
f6c2b19
to
a265a62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
cmd/in-toto/version.go
Outdated
// but what if the json package has a bug? :/ | ||
fmt.Println("commit : ", commit) | ||
fmt.Println("date : ", date) | ||
fmt.Println("version: ", tag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh this is an interesting way to set the vars. It does seem to be a simple way to do it though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about generating a JSON out of this, like kubectl does... would this format be better?
5ae173f
to
89edb03
Compare
I have made the following changes:
What needs to be done for getting this merged:
|
89edb03
to
a26f653
Compare
I think is ready to merge.. I have removed my test cosign public key. The new master key holder has to push the public key to the repository for enabling the releases via cosign |
cd4821b
to
570339c
Compare
Hello everybody, Note: The OIDC-Issuer feature is still considered experimental + the public rekor instance may change. |
friendly ping @shibumi, you might want to take a look at 👇 |
570339c
to
2ab7e8b
Compare
@developer-guy I have force-pushed to this branch. Have a look. |
LGTM @shibumi, thank you. |
2ab7e8b
to
1868e3d
Compare
1868e3d
to
15751b3
Compare
I have added SBOM generation and updated the goreleaser version |
15751b3
to
4c2b3ef
Compare
Fixes issue:
None
Description:
This PR adds signed releases via goreleaser and cosign. There are a few missing pieces we have to discuss:
Furthermore, this PR adds a new
in-toto version
subcommand. Goreleaser does not support SOURCE_DATE_EPOCH for reproducible builds yet, but a PR for this problem is already open: goreleaser/goreleaser#2510Please verify and check that the pull request fulfills the following
requirements: