Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move archivista helm chart from testifysec/charts to in-toto/a… #245

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

matglas
Copy link
Contributor

@matglas matglas commented Apr 22, 2024

Archivista

What this PR does / why we need it

Fixing #126

Which issue(s) this PR fixes (optional)

(optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged)*

Fixes #

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.19%. Comparing base (a035c62) to head (b9d298c).
Report is 57 commits behind head on main.

❗ Current head b9d298c differs from pull request most recent head bf1e791. Consider uploading reports for the commit bf1e791 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #245       +/-   ##
===========================================
- Coverage   82.40%   68.19%   -14.22%     
===========================================
  Files          10       11        +1     
  Lines         358      503      +145     
===========================================
+ Hits          295      343       +48     
- Misses         43      105       +62     
- Partials       20       55       +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kairoaraujo kairoaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the headers license in the new files. :)

chart/LICENSE Show resolved Hide resolved
@matglas
Copy link
Contributor Author

matglas commented Apr 23, 2024

All check passed and actions are done. I think it can merged in that case.

@kairoaraujo kairoaraujo merged commit d87c25b into in-toto:main Apr 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants