Table formatting logic overhaul #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2023
cyqsimon
force-pushed
the
table-layout-rewrite
branch
from
af9d7a3
to
59cb156
Compare
|
Rebased. |
cyqsimon
force-pushed
the
table-layout-rewrite
branch
from
59cb156
to
acf74c4
Compare
|
Rebased. |
- Columns now auto-expand and auto-shrink proportionally - Data column selection logic is now set per-table - Necessary boilerplate added to allow tables with more (or fewer) columns in the future
- These values are pretty much arbitrary. I'm open to further optimising them in the future.
cyqsimon
force-pushed
the
table-layout-rewrite
branch
from
3676895
to
6d9dae7
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #214. Will fix #276. Will fix #307.
Figure out what to do with the UI tests (see Fix flaky tests on the ci #303)