Improve/fix CI #279
Improve/fix CI #279
Conversation
- Remove `set +x` - Use GitHub Action's log grouping feature - See https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions
This does assume that the path `target/*/build/bandwhich-*/stderr` contains no spaces, but it should be fine.
|
All the infrastructure is in place. Awaiting reply from npcap devs. See nmap/npcap#227 |
|
Okay, pcap developers have responded and provided me with the relevant download link, but it does need to be kept private though. @imsnif I have sent you an email with the link and instructions; can you please help set it up using GitHub secrets? Thank you. |
|
Done! |
|
Retriggered CI |
|
Okay seems like CI is working now (finally). I've noticed there are some seemingly random extra draw events that are causing some tests to fail (sometimes intermittently), but these can be fixed in their own issue. I'll merge this for now. |
|
Probably should have used squash merge but whatever 😅 |
|
Maybe the windows issues are inpart due to windows report key events kind by default, see crossterm-rs/crossterm#805 crossterm-rs/crossterm#778 |
See also #277.