Feature, add PID column to processes table #165

olehs0 · 2020-04-12T15:42:29Z

Fixes #159.
Grab and show process identifier in a particular column to the processes table

olehs0 · 2020-04-12T16:09:51Z

Hello @imsnif! I don't know how to resolve conflicts in this file src/display/ui_state.rs, but i can try to do it. It seems there is some additional code which conflicted with my changes.

TheLostLambda · 2020-04-12T16:46:27Z

This is likely due to the recent update to Bandwhich adding cumulative usage tracking. There were changes to the table.rs, ui.rs, ui_state.rs, tests, and perhaps a few others. Unfortunately, there is no super easy solution. I would try to pull the latest version of the master branch on your machine and try a git rebase.

Most of the conflicts should be pretty easy to resolve, but it's possible that you'll need to do some more manual intervention. Let me know if you have any questions!

olehs0 · 2020-04-17T18:46:28Z

sorry, guys @TheLostLambda @imsnif , there is an issue with macos build and i cannot reproduce it on my local machine (arch linux). I tried rustup target add x86_64-apple-darwin and then build it via cargo build --target=x86_64-apple-darwin but getting errors(see a screenshot). so, could you please provide some suggestions/helps in this situation?

TheLostLambda · 2020-04-17T19:02:19Z

Hi @olehs0! I've done some cross-compilation in the past from Arch Linux an it's a little finicky. Have you installed apple-darwin-osxcross? That's needed to link binaries for Mac OS.

Let me know if installing that helps any!

olehs0 · 2020-04-17T19:58:42Z

Hi @olehs0! I've done some cross-compilation in the past from Arch Linux an it's a little finicky. Have you installed apple-darwin-osxcross? That's needed to link binaries for Mac OS.

Let me know if installing that helps any!

olehs0 · 2020-04-17T20:02:52Z

Hi @olehs0! I've done some cross-compilation in the past from Arch Linux an it's a little finicky. Have you installed apple-darwin-osxcross? That's needed to link binaries for Mac OS.

Let me know if installing that helps any!

thank you! i cannot build apple-darwin-osxcross because i have missed libc++ dependencies, so i'm going to resolve it. i'll ask you if i have any doubt.

imsnif · 2020-04-26T19:37:02Z

Hey @olehs0 - just a note: I will admit I could also never get cross-compiling working for macos. :)

The good news is that the macos version works on linux (it gets its info from lsof instead of the /proc filesystem which does not exist on mac). When I want to test stuff on mac, I usually just switch the "cfgs" around. So that everything that was "linux" becomes "macos" and the other way around. Hope that helps!

olehs0 · 2020-04-27T07:28:38Z

Hey @imsnif , ok, i see, thank you, i'll try to use it. anyway, i fixed that issues and now the PR is valid and has no conflicts.

olehs0 · 2020-04-28T13:05:05Z

Hi @imsnif ! Is everything fine there, or should I improve something else ?

imsnif · 2020-04-28T17:38:56Z

Hey @olehs0 - great work!
I will write more comments about the code, but before that - there is a behavior here I'd like changed.
Do you think we could change the "Processes" table, so that when it shrinks in size, we will always see the "rate" column? Meaning that the first column to disappear would be PID, then Connections? Or the other way around if you think it's better?

olehs0 · 2020-04-28T18:44:00Z

Hey @olehs0 - great work!
I will write more comments about the code, but before that - there is a behavior here I'd like changed.
Do you think we could change the "Processes" table, so that when it shrinks in size, we will always see the "rate" column? Meaning that the first column to disappear would be PID, then Connections? Or the other way around if you think it's better?

Sure, i think i can swap the rate up\down column with pid, is this will be fine ?

imsnif · 2020-04-28T18:56:24Z

Sure, i think i can swap the rate up\down column with pid, is this will be fine ?

Do you think we can keep them where they are and only change which ones disappear when we resize?

olehs0 · 2020-04-28T19:13:12Z

Probably it's not clear for me, how exactly user can resize the process table or all utilization tool? i guess i just swap rate with pid columns

imsnif · 2020-04-28T21:01:53Z

Don't swap the columns. "Rate" should be on the right.
In full size, we have:
Process, PID, Connections, Rate Up / Down

When resizing the window (making it smaller), we should have:
Process, PID, Rate Up / Down

IF you make it even smaller, you'll have only:
Process, Rate / Up Down

Does that make sense?

olehs0 · 2020-04-30T14:19:47Z

@imsnif yes, thank you for your explanation, let me try to rework it

olehs0 · 2020-06-03T20:46:31Z

sorry guys, i don't know how to implement it properly, could someone suggest something to me about the resizing ?

imsnif · 2020-06-06T07:21:49Z

Hey @olehs0, no worries - it's definitely a little tricky with the way things are written now.

What I like doing is starting simple, even if it means duplicating code. Then once everything works as I want it to, I try to refactor out the duplications.

I think a good direction here would be to move the ColumnCount (

bandwhich/src/display/components/table.rs

Line 28 in b25c035

pub enum ColumnCount {

) into the Table struct, and then have an if (or a match) in the render method that would deal with it.

Does that make sense? Or did you have issues in a different place? Please don't hesitate to ask. :)

olehs0 · 2020-06-10T06:59:02Z

Morning! Yeah I see, i got the idea. Thank you for your suggestion, let my work around it

imsnif · 2020-09-13T16:33:06Z

Hey, this was closed by mistake and I don't seem to be able to re-open it. Please feel free to re-open or make another PR with this if you wish. My apologies!

* feat: add `PID` column to `Process` table * fix(tests): populate fake data with the correct `ProcessInfo` type * test: update snapshots * refactor: use more idiomatic rust * refactor: rename function from `get_proc_name` to `get_proc_info` * refactor: only display PID when width available is highest ref: #165 (comment) * tests: update snapshots * chore: update CHANGELOG * fix: clippy warnings * Revert "fix: clippy warnings" This reverts commit e5f06cb. We will do this separately for the sake of keeping a clean history * refactor: use `u32` for PID * refactor: more idiomatic rust --------- Co-authored-by: cyqsimon <[email protected]>

olehs0 added 3 commits April 12, 2020 12:56

Add PID column in the processes table

a98ff52

Fix typo and display pid in process table

0675f6e

Add snapshots for tests

eb5f419

olehs0 changed the title ~~Feature/Add PID column to processes table~~ Feature, add PID column to processes table Apr 12, 2020

olehs0 added 2 commits April 13, 2020 20:44

Merge branch 'master' into feature/add-pid-column

1a61022

Fix through clippy

547446a

olehs0 closed this Apr 17, 2020

olehs0 reopened this Apr 17, 2020

olehs0 added 9 commits April 25, 2020 22:17

Move process_pid functionality into shared

868b95a

Apply cargo fmt -- --check

0419638

Fetch pid for macos

8c7fc2d

Get pub pid for raw connection

a598bb5

Typo

49ebdea

Add get_pid scenario for macos

c04b573

Forget comas

44ec18c

Update rustup version

5f7df57

Try to deref connection_data

f60bcb5

Rename process_pid to process_info

b25c035

imsnif closed this Sep 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature, add PID column to processes table #165

Feature, add PID column to processes table #165

olehs0 commented Apr 12, 2020

olehs0 commented Apr 12, 2020 •

edited

Loading

TheLostLambda commented Apr 12, 2020

olehs0 commented Apr 17, 2020 •

edited

Loading

TheLostLambda commented Apr 17, 2020

olehs0 commented Apr 17, 2020

olehs0 commented Apr 17, 2020

imsnif commented Apr 26, 2020

olehs0 commented Apr 27, 2020

olehs0 commented Apr 28, 2020

imsnif commented Apr 28, 2020

olehs0 commented Apr 28, 2020 •

edited

Loading

imsnif commented Apr 28, 2020 •

edited

Loading

olehs0 commented Apr 28, 2020 •

edited

Loading

imsnif commented Apr 28, 2020

olehs0 commented Apr 30, 2020

olehs0 commented Jun 3, 2020

imsnif commented Jun 6, 2020

olehs0 commented Jun 10, 2020

imsnif commented Sep 13, 2020

Feature, add PID column to processes table #165

Feature, add PID column to processes table #165

Conversation

olehs0 commented Apr 12, 2020

olehs0 commented Apr 12, 2020 • edited Loading

TheLostLambda commented Apr 12, 2020

olehs0 commented Apr 17, 2020 • edited Loading

TheLostLambda commented Apr 17, 2020

olehs0 commented Apr 17, 2020

olehs0 commented Apr 17, 2020

imsnif commented Apr 26, 2020

olehs0 commented Apr 27, 2020

olehs0 commented Apr 28, 2020

imsnif commented Apr 28, 2020

olehs0 commented Apr 28, 2020 • edited Loading

imsnif commented Apr 28, 2020 • edited Loading

olehs0 commented Apr 28, 2020 • edited Loading

imsnif commented Apr 28, 2020

olehs0 commented Apr 30, 2020

olehs0 commented Jun 3, 2020

imsnif commented Jun 6, 2020

olehs0 commented Jun 10, 2020

imsnif commented Sep 13, 2020

olehs0 commented Apr 12, 2020 •

edited

Loading

olehs0 commented Apr 17, 2020 •

edited

Loading

olehs0 commented Apr 28, 2020 •

edited

Loading

imsnif commented Apr 28, 2020 •

edited

Loading

olehs0 commented Apr 28, 2020 •

edited

Loading