-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause UI with <SPACE> #106
Conversation
Hah! This looks cool :)
|
What about a help section a la top? Maybe not for now, but if we add more interaction the UI could end up cluttered otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉
} else { | ||
Text::styled( | ||
format!( | ||
" Total Rate Up / Down: {} / {}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems rather verbose. Shouldn't we optionally append the [PAUSED]
string if self.paused
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately rust requires that format strings must be literals... Plus, the color argument will have to be different, so I just expanded this expression
Added a test case for this... Regarding communicating this to user, I'm worried about cluttering the UI. This needs some discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat!
I left a couple comments, the rest LGTM!
An attempt to issue #74
When the UI is paused, text will turn yellow, and there will be a "[PAUSED]" string displayed