-
-
Notifications
You must be signed in to change notification settings - Fork 298
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix non-deterministic test
pause_by_space
There was no sleep between unpause and exit, causing a race condition on some terminal emulators, which is the root cause of random CI failures on Windows. However, it's important to note that the "failure case" we saw on Windows is actually the correct expected case of the test. On Linux and MacOS, the race always resolves one way, causing the unpause event to be in practise untested. To fix it, I simply made sure events are always separated by sleeps.
- Loading branch information
Showing
2 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters