Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Apollo to version 3.0.2 and fix crash when adding product without image to cart #33

Merged
merged 8 commits into from
Aug 2, 2020

Conversation

w3bdesign
Copy link
Contributor

@w3bdesign w3bdesign commented Jul 25, 2020

  • Minimize dependency on external packages by replacing Lodash isEmpty with custom function
  • Updated all NPM packages
  • Fix site crashing if we add a product without an image to cart
  • Upgraded Apollo from v 2.6 to 3.0.2
  • Replaced Ruby Markdown in README with Javascript Markdown
  • Fix incorrect country code for India (was ID for Indonesia)
  • Fix spelling error in OrderSuccess
  • Implemented Nprogress with Next Router to display a loading indicator for visual feedback

TODO:

Take a look at reintroducing FragmentMatcher.
See apollographql/apollo-client#5073 and https://www.apollographql.com/docs/react/data/fragments/#defining-possibletypes-manually

Npm packages should be regularly updated
Replaced all package imports to use @apollo/client and remove unused packages from package.json
@w3bdesign w3bdesign changed the title Replace lodash isEmpty dependency with custom function Upgrade Apollo to version 3.0.2 and fix crash when adding product without image to cart Jul 25, 2020
@imranhsayed
Copy link
Owner

@w3bdesign
Thank you for the contribution.
I see that when you add a product ot the cart, and go the the cart page. The cart page does not reflect any changes.
Can you please test it at your end ?

image

@w3bdesign
Copy link
Contributor Author

@imranhsayed

Is the WooCommerce installation local or remote?

I found out that if I use Xampp, the update takes a minute or two, but is really fast on an online installation.

I recommend that you experiment with a different WooCommerce installation and see if that may be the reason.

@imranhsayed
Copy link
Owner

@w3bdesign
I had tested it online as well. Can you try deploying your branch on netlify or vercel and test it once.
Could you also raise a fresh PR please, as there had been changes after hat ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants