fix: support package.json browser field#150
Merged
imranbarbhuiya merged 2 commits intoimranbarbhuiya:mainfrom Aug 23, 2023
Merged
fix: support package.json browser field#150imranbarbhuiya merged 2 commits intoimranbarbhuiya:mainfrom
imranbarbhuiya merged 2 commits intoimranbarbhuiya:mainfrom
Conversation
1 task
markdalgleish
force-pushed
the
package-browser-field
branch
2 times, most recently
from
3c5b7ea to
17c8613
Compare
markdalgleish
force-pushed
the
package-browser-field
branch
from
17c8613 to
515c843
Compare
imranbarbhuiya
requested changes
Aug 23, 2023
imranbarbhuiya
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an issue raised against Remix (remix-run/remix#7095) where a dependency used the
browserfield inpackage.jsonto omit thecryptopolyfill from browser builds but the polyfill was still being included. This is particularly important in this case because the polyfill is quite large. However, even though esbuild natively supports thebrowserfield, this plugin's resolver is being given a higher priority. This PR adds a check for thebrowserfield and returns an empty module if it'sfalse, or bails out of resolving the polyfill if a file path is detected.Status and versioning classification: