feat: support process
and Buffer
globals
#121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature based on an issue reported against Remix: remix-run/remix#6665
In the linked issue (once the fix in #120 has been applied) the build fails due to a package that assumes the
process
global is available.To address this scenario, this PR adds a new
globals
option to the plugin. In order to make this a non-breaking change, right now it's optional and disabled by default.I realise there's a few details in this PR that you might want to change, particularly around the API and its surface area, but I thought this would be a good way to start the conversation at least.
Status and versioning classification: