Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-proxy fix + Go dep + Update/Lock Dependencies #102

Merged
merged 8 commits into from
Nov 22, 2017
Merged

grpc-proxy fix + Go dep + Update/Lock Dependencies #102

merged 8 commits into from
Nov 22, 2017

Conversation

MarcusLongmuir
Copy link
Contributor

This is an unfortunately large PR to fix the build, but in doing so it will lock down the dependencies that were the cause of the broken build.

Replaces #101 as the build is now broken and this PR will fix it. (Fixes #84 and #91)

Includes:

  • Using fix in grpcproxy here
  • Added godep to manage Golang dependencies.
  • Added package.lock.json for locking npm dependencies.
  • Fixed nodeHttp transport usage of Metadata/Browserheaders - this issue was caused by the node types updating.

@MarcusLongmuir MarcusLongmuir mentioned this pull request Nov 22, 2017
Closed
@MarcusLongmuir MarcusLongmuir merged commit be0c2b3 into master Nov 22, 2017
@MarcusLongmuir MarcusLongmuir deleted the go-dep branch November 22, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ains ains ains approved these changes

@mwitkow mwitkow Awaiting requested review from mwitkow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing token based auth through proxy?
2 participants
@MarcusLongmuir @ains