fix(user/followers): return actor url

[uvok]

First up, I'm not sure what the ActivityPub spec says.
But using the "id" used by hatsu in the followers collection does seem strange to me. At least all the "URLs" in the collection lead to a 404 page. It seems using the actual "actor" (follower) URL is better? At least a tool like https://browser.pub seems to deal better with that. (See e.g. https://browser.pub/https://blog.uvokchee.de).

What do you think?

Summary by CodeRabbit

• Bug Fixes
  • Improved user follower URL generation mechanism to ensure accurate mapping of follower information.

[coderabbitai]

Walkthrough

The pull request introduces a modification in the user_followers.rs file, specifically changing how follower URLs are mapped. Instead of using follow.id for URL generation, the code now uses follow.actor. This adjustment impacts the way follower URLs are processed within the handler function, potentially altering the data representation of user followers while maintaining the existing function's overall structure and pagination logic.

Changes

File	Change Summary
crates/api_apub/src/users/user_followers.rs	Modified URL mapping from follow.id to follow.actor in the handler function

Poem

🐰 Hop, hop, through the code's domain,
Where followers' paths now softly reign,
From id to actor, a subtle dance,
A rabbit's tweak with algorithmic glance!
URLs transformed, yet logic stays true,
In the realm of followers, both old and new. 🌐

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/api_apub/src/users/user_followers.rs (1)

81-81: Consider more robust error handling for follower URLs
Relying on .filter_map(Result::ok) means any parsing errors will silently drop followers from the collection. If invalid or malformed URLs are unexpected, consider logging or returning an error rather than ignoring them. This ensures more transparent error reporting and helps diagnose faulty data.

Below is an example change to explicitly handle parsing failures:

 .map(|follow| {
-    Url::parse(&follow.actor)
-})
-.filter_map(Result::ok)
+.map(|follow| {
+    match Url::parse(&follow.actor) {
+        Ok(url) => Some(url),
+        Err(e) => {
+            // Consider logging or returning an error here
+            tracing::warn!("Invalid follower URL: {}", e);
+            None
+        }
+    }
+})
+.flatten()

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04c15cf and d074952.

📒 Files selected for processing (1)

• crates/api_apub/src/users/user_followers.rs (1 hunks)

[kwaa]

Indeed, it seems I accidentally made a mistake. Thank you for your contribution!