Fix resolve install in old npm version on CI.#3237
Open
rasmi wants to merge 1 commit intoimport-js:mainfrom
Open
Fix resolve install in old npm version on CI.#3237rasmi wants to merge 1 commit intoimport-js:mainfrom
rasmi wants to merge 1 commit intoimport-js:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3237 +/- ##
==========================================
+ Coverage 95.39% 95.50% +0.10%
==========================================
Files 83 83
Lines 3689 3689
Branches 1332 1332
==========================================
+ Hits 3519 3523 +4
+ Misses 170 166 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ljharb
reviewed
Mar 12, 2026
tests/dep-time-travel.sh
Outdated
Comment on lines
+48
to
+49
| echo "Installing resolver dependencies..." | ||
| (cd resolvers/node && npm install) |
Member
There was a problem hiding this comment.
this should probably run for every subdir inside resolvers, so it covers the webpack one too
fenichelar
reviewed
Mar 16, 2026
Author
|
Extended timeout on the one failing test for old macos as it just takes a little longer for the initial webpack resolver load. |
ljharb
approved these changes
Mar 18, 2026
|
Since it was already approved, what is stopping this from being merged to unblock #3230 to unblock jsx-eslint/eslint-plugin-react#3979? |
2bd1e28 to
154a5e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Node < 10 in CI,
linklocalreplaces the published resolver with a symlink to the local source, but old npm doesn't install the local source's nested dependencies, so resolve@2 (added in 9222532) is missing and the resolver crashes. The fix adds(cd resolvers/node && npm install)todep-time-travel.shto install the missing nested deps before tests run.Also, extends the timeout for the first webpack resolver test on old node + macos because it's a bit over the current 5s timeout. The initial load here takes longer.