Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack Resolver fix for case config is an array of functions #1220

Merged
merged 4 commits into from
Oct 25, 2018
Merged

Webpack Resolver fix for case config is an array of functions #1220

merged 4 commits into from
Oct 25, 2018

Conversation

idudinov
Copy link
Contributor

@idudinov idudinov commented Oct 22, 2018 •
edited by ljharb
Loading

Fixes #1219

  • aded test for the case

@ljharb ljharb requested a review from benmosher October 22, 2018 20:24
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 97.356% when pulling f4f4137 on idudinov:webpack_fix into b4a2f11 on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 97.356% when pulling f4f4137 on idudinov:webpack_fix into b4a2f11 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 97.356% when pulling f4f4137 on idudinov:webpack_fix into b4a2f11 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 97.356% when pulling f4f4137 on idudinov:webpack_fix into b4a2f11 on benmosher:master.

@coveralls
Copy link

coveralls commented Oct 22, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 97.356% when pulling 2ea4a2a on idudinov:webpack_fix into b4a2f11 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 97.356% when pulling f4f4137 on idudinov:webpack_fix into b4a2f11 on benmosher:master.

vikr01
vikr01 suggested changes Oct 24, 2018
View reviewed changes
resolvers/webpack/index.js Outdated Show resolved Hide resolved
benmosher
benmosher approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@benmosher benmosher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM

@benmosher benmosher merged commit db471a8 into import-js:master Oct 25, 2018
@idudinov idudinov deleted the webpack_fix branch October 25, 2018 10:59
@idudinov
Copy link
Contributor Author

idudinov commented Nov 2, 2018

Hi @benmosher! Thanks for approving my PR.
Is there any chance to release this to NPM?
I would not bother you with this if there was a way to reference this version package directly in package.json (subdirectories do not work).

@vikr01
Copy link
Contributor

vikr01 commented Nov 2, 2018

@idudinov You could try installing with github and using "eslint-plugin-import/resolvers/webpack" instead of "webpack". (Though, I really recommend not doing this.)

@benmosher
Copy link
Member

just finally released! sorry for the delay!

This was referenced Sep 16, 2021
Open
Open
This was referenced Dec 31, 2021
Open
Open
Open
This was referenced Jun 21, 2023
Open
Open
Open
This was referenced Nov 30, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikr01 vikr01 vikr01 requested changes

@benmosher benmosher benmosher approved these changes

Assignees
No one assigned
Labels
bug package: resolver/webpack
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESLint error: Cannot read property 'externals' of undefined
5 participants
@idudinov @coveralls @vikr01 @benmosher @ljharb