Simplified no-require. Close #88.

README.md

@@ -18,7 +18,7 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 
 Helpful warnings:
 
-* Report CommonJS `require` of ES6 module. ([`no-require`](#no-require))
+* Report CommonJS `require` calls. ([`no-require`](#no-require))
 * Report use of exported name as identifier of default export ([`no-named-as-default`](#no-named-as-default))
 * Report repeated import of the same module in multiple places ([`no-duplicates`](#no-duplicates), warning by default)
 
@@ -106,10 +106,10 @@ For [ES7], reports if an exported namespace would be empty (no names exported fr
 
 ### `no-require`
 
-Reports `require` of modules with ES named or default exports. Off by default.
+Reports `require([string])` function calls. Will not report if >1 argument,
+or single argument is not a literal string.
 
-Will warn on core modules and unresolved modules, but will not warn on a userland
-module that is obviously CommonJS.
+Intended for temporary use when migrating to pure ES6 modules.
 
 Given:
 ```js
@@ -121,19 +121,11 @@ export function bar() { return foo }
 exports.something = 'whatever'
 ```
 
-...this is valid:
-```js
-import { foo, bar } from './mod'
-const { something } = require('common')
-
-import fs from 'fs' // core module
-import { whatever } from './not-found'
-```
-
-...and this would be reported:
+This would be reported:
 
 ```js
 var mod = require('./mod')
+  , common = require('./common')
   , fs = require('fs')
   , whateverModule = require('./not-found')
 ```

package.json

@@ -43,7 +43,7 @@
     "mocha": "^2.2.1"
   },
   "peerDependencies": {
-    "eslint": ">=0.16.0"
+    "eslint": ">=1.4.0"
   },
   "dependencies": {
     "babel-runtime": "5.x",

src/rules/no-require.js

@@ -1,5 +1,3 @@
-import Exports from '../core/getExports'
-
 module.exports = function (context) {
   return {
     'CallExpression': function (call) {
@@ -12,11 +10,11 @@ module.exports = function (context) {
       if (module.type !== 'Literal') return
       if (typeof module.value !== 'string') return
 
-      var imports = Exports.get(module.value, context)
-      if (!imports || imports.hasDefault || imports.hasNamed) {
-        context.report(call.callee,
-          'CommonJS require of ES module \'' + module.value + '\'.')
-      }
+      // keeping it simple: all 1-string-arg `require` calls are reported
+      context.report({
+        node: call.callee,
+        message: `CommonJS require of module '${module.value}'.`
+      })
     }
   }
 }

tests/src/rules/no-require.js

@@ -6,28 +6,32 @@ const ruleTester = new RuleTester()
 
 ruleTester.run('no-require', rule, {
   valid:
-    [ test({ code: "var foo = require('./common');" })
-    , test({ code: "var bar = require('./bar', true);" })
+    [ test({ code: "var bar = require('./bar', true);" })
     , test({ code: "var bar = proxyquire('./bar');" })
     , test({ code: "var bar = require('./ba' + 'r');" })
     , test({ code: 'var zero = require(0);' })
-
-    , test({ code: 'function () { var bar = require("./bar"); }' })
-    , test({ code: 'var bar = require("./bar")'
-           , settings: { 'import/ignore': ['bar'] } })
     ],
 
   invalid:
-    [ test({ code: "var bar = require('./bar');"
+    [ test({ code: "var foo = require('./common');"
+           , errors: 1 })
+      // future: maybe a rule option that doesn't report on anything
+      //         but top-level scoped requires?
+    , test({ code: 'function () { var bar = require("./bar"); }'
+           , errors: 1 })
+    , test({ code: 'var bar = require("./bar")'
+           , settings: { 'import/ignore': ['bar'] }
+           , errors: 1 })
+    , test({ code: "var bar = require('./bar');"
            , errors:
-             [ { message: "CommonJS require of ES module './bar'."
+             [ { message: "CommonJS require of module './bar'."
                , type: 'Identifier'
                }
              ]
            })
     , test({ code: "(function () { var bar = require('./bar'); }());"
            , errors:
-             [ { message: "CommonJS require of ES module './bar'."
+             [ { message: "CommonJS require of module './bar'."
                , type: 'Identifier'
                }
              ]