Breaking change: implicit es6-only for all rules. (closes #20)

lib/getExports.js

@@ -3,7 +3,6 @@
 var
   Map = require("es6-map"),
   Set = require("es6-set"),
-  traverse = require("estraverse").traverse,
   parse = require("./parse"),
   resolve = require("./resolve"),
   isCore = require("resolve").isCore;
@@ -16,7 +15,6 @@ function ExportMap(context) {
   this.hasDefault = false;
   this.named = new Set();
 
-  this.isCommon = false;
   this.errors = [];
 }
 
@@ -41,11 +39,7 @@ ExportMap.get = function (source, context) {
 ExportMap.parse = function (path, context) {
   var m = new ExportMap(context);
 
-  if (isCore(path)) {
-    // skip parsing, mark as common
-    m.isCommon = true;
-    return m;
-  }
+  if (isCore(path)) return m; // skip parsing
 
   try {
     var ast = parse(path);
@@ -60,8 +54,6 @@ ExportMap.parse = function (path, context) {
     m.captureNamedDeclaration(n);
   });
 
-  m.commonJs(ast);
-
   return m;
 };
 
@@ -101,29 +93,4 @@ ExportMap.prototype.captureNamedDeclaration = function (n) {
   }.bind(this));
 };
 
-// todo: capture names
-ExportMap.prototype.commonJs = function (ast) {
-  var map = this;
-  try {
-    traverse(ast, {
-      fallback: "iteration",
-      enter: function (n) {
-        if (n.type !== "AssignmentExpression") return;
-
-        if (n.operator !== "=") return;
-        if (n.left.type !== "MemberExpression") return;
-
-        if (n.left.object.type !== "Identifier") return;
-
-        if (n.left.object.name === "module" || n.left.object.name === "exports") {
-          map.isCommon = true;
-          this.break();
-        }
-      }
-    });
-  } catch (err) {
-    this.errors.push(err);
-  }
-};
-
 module.exports = ExportMap.get;

lib/rules/default.js

@@ -13,9 +13,6 @@ module.exports = function (context) {
       var imports = getExports(node.source.value, context);
       if (imports == null) return;
 
-      if (imports.named.size === 0 && context.options[0] !== "es6-only")
-        return; // ignore for commonjs compatibility
-
       if (!imports.hasDefault)
         context.report(defaultSpecifier, "No default export found in module.");
     }

lib/rules/named.js

@@ -13,11 +13,6 @@ module.exports = function (context) {
 
       var names = imports.named;
 
-      // if there are no exports, may be a commonjs module.
-      // TODO: "interop" mode that attempts to read module.exports, exports member assignments?
-      if (names.size === 0 && !imports.hasDefault && context.options[0] !== "es6-only")
-        return;
-
       node.specifiers.forEach(function (im) {
         if (im.type !== "ImportSpecifier") return;
 

lib/rules/namespace.js

@@ -19,7 +19,7 @@ module.exports = function (context) {
       var declaration = importDeclaration(context);
 
       var imports = getExports(declaration.source.value, context);
-      if (imports == null || imports.isCommon) return;
+      if (imports == null) return;
 
       if (imports.named.size === 0)
         context.report(namespace,

tests/lib/rules/default.js

@@ -9,7 +9,6 @@ var test = require("../../utils").test;
 
 eslintTester.addRuleTest("lib/rules/default", {
   valid: [
-    test({code: "import crypto from 'crypto';"}),
     test({code: "import foo from './empty-folder';"}),
     test({code: "import { foo } from './default-export';"}),
     test({code: "import foo from './default-export';"}),
@@ -19,19 +18,19 @@ eslintTester.addRuleTest("lib/rules/default", {
     test({
       code: "import CoolClass from './default-class';"}),
     test({
-      code: "import bar, { baz } from './default-export';"}),
-    test({
-      code: "import bar from './common';"})
+      code: "import bar, { baz } from './default-export';"})
   ],
 
   invalid: [
+    test({
+      code: "import crypto from 'crypto';",
+      errors: [{message: "No default export found in module.", type: "ImportDefaultSpecifier"}]}),
     test({
       code: "import baz from './named-exports';",
       errors: [{message: "No default export found in module.", type: "ImportDefaultSpecifier"}]}),
 
     test({
       code: "import bar from './common';",
-      args: [2, "es6-only"],
       errors: [{message: "No default export found in module.", type: "ImportDefaultSpecifier"}]})
   ]
 });

tests/lib/rules/named.js

@@ -17,15 +17,18 @@ eslintTester.addRuleTest("lib/rules/named", {
     test({code: "import { foo } from './bar';"}),
     test({code: "import { foo } from './empty-module';"}),
     test({code: "import bar from './bar.js';"}),
+    test({code: "import bar, { foo } from './bar.js';"}),
     test({code: "import {a, b, d} from './named-exports';"}),
     test({code: "import {ExportedClass} from './named-exports';"}),
-    test({code: "import {a, b, d} from './common';"}),
     test({code: "import { ActionTypes } from './qc';"}),
     test({code: "import {a, b, c, d} from './re-export';"}),
     test({code: "import {foo, bar} from './re-export-names';", args: [2, "es6-only"]})
   ],
 
   invalid: [
+    test({code: "import {a, b, d} from './common';",
+      errors: [error("a", "./common"), error("b", "./common"), error("d", "./common")]}),
+
     test({code: "import { baz } from './bar';",
       errors: [error("baz", "./bar")]}),
 

tests/lib/rules/namespace.js

@@ -15,7 +15,6 @@ function error(name, namespace) {
 eslintTester.addRuleTest("lib/rules/namespace", {
   valid: [
     test({code: "import * as foo from './empty-folder';"}),
-    test({code: "import * as foo from './common';"}),
     test({code: "import * as names from './named-exports'; console.log((names.b).c); "}),
 
     test({code: "import * as names from './named-exports'; console.log(names.a); "}),
@@ -24,6 +23,8 @@ eslintTester.addRuleTest("lib/rules/namespace", {
   ],
 
   invalid: [
+    test({code: "import * as foo from './common';",
+          errors: ["No exported names found in module './common'."]}),
     test({code: "import * as names from './default-export';",
           errors: ["No exported names found in module './default-export'."]}),