Skip to content

feat: import with .js and .jsx file extensions#56

Merged
JounQin merged 3 commits intoimport-js:masterfrom
gcangussu:master
Sep 1, 2020
Merged

feat: import with .js and .jsx file extensions#56
JounQin merged 3 commits intoimport-js:masterfrom
gcangussu:master

Conversation

@gcangussu
Copy link
Copy Markdown
Contributor

fixes #55

@JounQin
Copy link
Copy Markdown
Collaborator

JounQin commented Sep 1, 2020

Thanks! I would say it's a good feature instead of a bug fix.

@JounQin JounQin self-requested a review September 1, 2020 02:21
Comment thread src/index.ts Outdated
@gcangussu gcangussu changed the title fix: import with .js and .jsx file extension feat: import with .js and .jsx file extensions Sep 1, 2020
@gcangussu
Copy link
Copy Markdown
Contributor Author

Thanks! I would say it's a good feature instead of a bug fix.

Sure. I've renamed the PR to reflect that. Let me know if I should squash all commits and amend the commit message on my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Fails when importing with .js/.jsx extensions

2 participants