Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3205] Support WebGL #283

Merged
merged 17 commits into from
Oct 9, 2024
Merged

[SDK-3205] Support WebGL #283

merged 17 commits into from
Oct 9, 2024

Conversation

andrew-yangy
Copy link
Collaborator

@andrew-yangy andrew-yangy commented Sep 5, 2024 •
edited
Loading

Summary

Add support for WebGL

@andrew-yangy andrew-yangy requested a review from a team as a code owner September 5, 2024 05:49
nattb8
nattb8 reviewed Oct 8, 2024
View reviewed changes
sample/Assets/Scripts/SelectAuthMethodScript.cs Outdated Show resolved Hide resolved
sample/Assets/Scripts/SelectAuthMethodScript.cs Outdated Show resolved Hide resolved
sample/Assets/Scripts/SelectAuthMethodScript.cs Outdated Show resolved Hide resolved
nattb8
nattb8 reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@nattb8 nattb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw that you changed the redirect and logout redirect URIs, when adding webGL to the sample app, can you make sure it still works on the other platforms? and for both PKCE and Device Code Auth.

nattb8
nattb8 previously approved these changes Oct 9, 2024
View reviewed changes
@andrew-yangy andrew-yangy merged commit b6b3eb6 into main Oct 9, 2024
18 checks passed
@andrew-yangy andrew-yangy deleted the feature/sdk-3205-webgl branch October 9, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nattb8 nattb8 nattb8 approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-yangy @nattb8