Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX-2622] fix: android custom tabs version, build immutable android library as aar #160

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Feb 1, 2024

Summary

  • Change Chrome Custom Tabs version to 1.5.0 so the compileSdkVersion can be 33
  • Import ImmutableAndroid as an .aar file instead of including it as a library .androidlib. so build tools version is not hardcoded
  • Updated sample app to not include ImmutableActivity and CustomTabsService in AndroidManifest.xml as they are not required

Customer Impact

  • Customers can now set the compileSdkVersion to API 33 on Unity 2022+

Other things to consider:

@nattb8 nattb8 requested a review from a team as a code owner February 1, 2024 00:17
YermekG
YermekG previously approved these changes Feb 1, 2024
@nattb8 nattb8 merged commit 0ff445c into main Feb 1, 2024
12 checks passed
@nattb8 nattb8 deleted the fix/android-newer-unity-versions branch February 1, 2024 01:18
@github-actions github-actions bot added the fix label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants