Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX-2600] fix: custom tabs dismiss callback triggered before redirect #153

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Jan 22, 2024

Summary

If the user is logged into the browser and uses LoginPKCE / ConnectImxPKCE, Chrome Custom Tabs will immediately redirect them back to the game. However, there are instances when the Custom Tabs dismiss callback is called before the redirect, rendering the PKCE CompletionSource null. This means that the PKCE result cannot be returned to the game.

To prevent this issue, I have added some delay before calling onCustomTabsDismissed.

Customer Impact

N/A

@nattb8 nattb8 requested a review from a team as a code owner January 22, 2024 21:27
@nattb8 nattb8 changed the title fix: custom tabs dismiss callback triggered before redirect [DX-2600] fix: custom tabs dismiss callback triggered before redirect Jan 22, 2024
@nattb8 nattb8 merged commit 02a84ba into main Jan 22, 2024
12 checks passed
@nattb8 nattb8 deleted the fix/custom-tabs-dismiss-before-redirect branch January 22, 2024 21:47
@github-actions github-actions bot added the fix label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants