-
Notifications
You must be signed in to change notification settings - Fork 37
feat(checkout): Migrate to v2 sanction API and add token info #2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fang377
wants to merge
31
commits into
main
Choose a base branch
from
CORE-2583-Integrate-V2-Sanction-API
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
2d41268
Migrate to v2 sanction API and add token info
fang377 ea81125
Fix linter
fang377 e549752
Fix test
fang377 2a332f3
Add token info in sale context
fang377 0a18d90
Mark token info as non-optional in v2 sanction
fang377 389da8a
Fix linting
fang377 26ac3b5
Fix test
fang377 754805f
Fix linting
fang377 094778b
Avoid invalid token info
fang377 65f1387
Fix linting
fang377 dd6fa2d
Fix linting
fang377 ffeba32
Fix linting
fang377 3c4ee62
Fix linting
fang377 4fa0fb8
Make token addr and amount required in v2 request
fang377 24141fd
Fix build
fang377 3d2e8c2
Fix linting
fang377 8f5d2b1
Fix addToken
fang377 5917288
Fix addToken
fang377 99194c6
Fix addToken
fang377 df4292b
Fix widgets
fang377 da53818
Fix linting
fang377 d51ca86
Fix build
fang377 94a4ceb
Fix bridgeForm
fang377 0671d68
Update packages/checkout/widgets-lib/src/widgets/add-tokens/views/Add…
fang377 698ff0e
Update packages/checkout/widgets-lib/src/widgets/add-tokens/views/Add…
fang377 72aed4f
Update packages/checkout/widgets-lib/src/widgets/add-tokens/views/Add…
fang377 265cb8a
Update packages/checkout/widgets-lib/src/widgets/bridge/components/Br…
fang377 f0c9eca
Update packages/checkout/widgets-lib/src/widgets/bridge/components/Br…
fang377 62c0846
Update packages/checkout/widgets-lib/src/widgets/sale/context/SaleCon…
fang377 d689bb3
Fix linting
fang377 0d11549
Merge branch 'main' into CORE-2583-Integrate-V2-Sanction-API
keithbro-imx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what scenario would the token and amount data not be available?
Should we still send through a request to the sanctions service without this information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea the request should still be sent even when token and amount data are not available,
like the sale context (where token/amount are determined later in the flow), early-stage widget initialization (before user selects token/amount), and generic address validation (where we just want to check if an address is sanctioned regardless of specific transaction details) etc