Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ID-2589 Add json rpc referrer as optional param and set on game bridge #2332

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

imx-mikhala
Copy link
Contributor

@imx-mikhala imx-mikhala commented Oct 18, 2024

Hi👋, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

Summary

  • Sets jsonRpcReferrer as optional param on Passport so when external partners use crossSdkBridgeEnabled the referrer isnt also set in zkEvmProvider.ts

Detail and impact of the change

Added

Changed

Deprecated

Removed

Fixed

Security

Anything else worth calling out?

@imx-mikhala imx-mikhala requested review from a team as code owners October 18, 2024 05:05
@imx-mikhala imx-mikhala marked this pull request as draft October 18, 2024 05:06
@imx-mikhala imx-mikhala changed the title ID-2589 Add json rpc referrer as optional param and set on game bridge refactor: ID-2589 Add json rpc referrer as optional param and set on game bridge Oct 18, 2024
@imx-mikhala imx-mikhala marked this pull request as ready for review October 18, 2024 05:08
Copy link

nx-cloud bot commented Oct 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7d9fd7a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

haydenfowler
haydenfowler previously approved these changes Oct 18, 2024
@imx-mikhala imx-mikhala added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@imx-mikhala imx-mikhala added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit f8a7134 Oct 18, 2024
9 checks passed
@imx-mikhala imx-mikhala deleted the ID-2589-jsonRpcReferrer branch October 18, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants