-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hybrid ERC721 Minting #56
base: main
Are you sure you want to change the base?
Conversation
|
||
import { AccessControlEnumerable } from "@openzeppelin/contracts/access/AccessControlEnumerable.sol"; | ||
|
||
abstract contract ERC721AccessControl is AccessControlEnumerable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want to refer to this as ERC721AccessControl
as then it implies in implements ERC721 interfaces. Maybe we should rename it to just ImmutableAccessControl
something else?
All other ERC721 functions are supported, with routing logic depending on the tokenId. | ||
*/ | ||
|
||
abstract contract ERC721HybridMinting is ERC721PsiBurnable, ERC721 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have this extend ERC721Royalty
instead of ERC721
since ERC721Royalty
already extends ERC721
?
|
||
// | ||
function _safeMint(address to, uint256 quantity) internal virtual override(ERC721, ERC721Psi) { | ||
return super._safeMint(to, quantity); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if it makes sense to explicitly override and call ERC721Psi._safeMint(to, quantity)
here since thats what is actually being called. Same for the two overrides below
@alex-connolly this PR appears to be stale, and superseded by newer work. Should this PR be abandoned? |
No description provided.