Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android build #51

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Android build #51

merged 9 commits into from
Apr 15, 2024

Conversation

JW-CH
Copy link
Collaborator

@JW-CH JW-CH commented Apr 10, 2024

No description provided.

@JW-CH JW-CH added the enhancement New feature or request label Apr 10, 2024
@BlakeFL
Copy link

BlakeFL commented Apr 10, 2024

If you need an Android beta tester, let me know. I have an old Fire Tablet waiting for an APK.

@JW-CH
Copy link
Collaborator Author

JW-CH commented Apr 11, 2024

If you need an Android beta tester, let me know. I have an old Fire Tablet waiting for an APK.

Thank you. Feel free to create issues once we are happy with the state of the android build ;)

ImmichFrame/Models/Settings.cs Outdated Show resolved Hide resolved
@JW-CH
Copy link
Collaborator Author

JW-CH commented Apr 15, 2024

Hey @BlakeFL, if you want to, there is a prerelease version for android: https://github.com/3rob3/ImmichFrame/releases/tag/v1.0.0.10-alpha apk is attached to the release.

@JW-CH JW-CH marked this pull request as ready for review April 15, 2024 07:34
@JW-CH JW-CH added enhancement New feature or request and removed enhancement New feature or request labels Apr 15, 2024
@BlakeFL
Copy link

BlakeFL commented Apr 15, 2024

Hey @BlakeFL, if you want to, there is a prerelease version for android: https://github.com/3rob3/ImmichFrame/releases/tag/v1.0.0.10-alpha apk is attached to the release.

I will try it out later today. Thanks!

@BlakeFL
Copy link

BlakeFL commented Apr 15, 2024

The apk worked well. It is showing images from my server and the weather api is working. A few observations though...

  • I messed up the settings the first attempt and there was no prompt to return back to that screen. I closed out of the app a few times and was eventually taken back and I corrected the issue.
  • On the settings page all the text boxes are very small for me.
  • For the weather, I don't believe the city name is necessary. To reduce vertical space, an image might be better next to the temperature instead of "Clear Sky" below. I also do not care about decimals in the temp so that could free up space as well.

@3rob3
Copy link
Collaborator

3rob3 commented Apr 15, 2024

  • You can get back to setting at any time by pressing/clicking the upper middle quadrant. The documentation will be updated once we merge this.
  • What size device and resolution? This is going to be tough to get perfect on all devices unfortunately.
  • I mostly agree with the city comment, might need to make it an optional setting. Not sure about decimal places in temperature, it might be useful when showing Celsius. I personally like the text description for current conditions over a tiny icon.

@JW-CH
Copy link
Collaborator Author

JW-CH commented Apr 15, 2024

image
Updated the textboxes, I wanted to do this before :)

For the other things: these are not really android related. I'd prefer to leave them right now and create new issues for them.

@3rob3 3rob3 merged commit 76c1bf8 into main Apr 15, 2024
2 checks passed
@JW-CH JW-CH deleted the dev.jw.android branch April 15, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants