Skip to content

Pull Request: Add Chronological Images Set Feature #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoeRu wants to merge 16 commits into from
Closed

Pull Request: Add Chronological Images Set Feature #481

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6bb4b1c
Images are grouped by their capture date and
JoeRu Oct 4, 2025
b9961cf
CodeRabbit suggestion ChronologicalImagesCount is
JoeRu Oct 4, 2025
175c586
Adapted Test.json files to match testcases.
JoeRu Oct 5, 2025
04e35a3
Problem with date-time parser and tests
JoeRu Oct 5, 2025
fbc0217
Remove errors in the above files before committing.
JoeRu Oct 6, 2025
2d243be
📋 Changelog: Parameter Simplification & Enhanced Testing
JoeRu Oct 7, 2025
6fa99c2
Updates of tests - as Tags for dev-test has been removed. Mocks are n…
JoeRu Oct 7, 2025
6dd8de3
fix: Standardize unit test mock constructors and
JoeRu Oct 9, 2025
a5b1c70
Completed the task of removing the unused IGeneralSettings generalSet…
JoeRu Oct 23, 2025
0b3b361
initial draft of RandomDateAssetsPool with cluster-based date selection
JoeRu Oct 26, 2025
1c76a53
- Goal: Provide balanced random photo selection across a library’s en…
JoeRu Oct 26, 2025
5135110
Problem Solved
JoeRu Oct 27, 2025
9c8d089
Fixed multiple performance and quality issues in the random photo sel…
JoeRu Oct 27, 2025
96ed232
smaller adaptions to fit ordering and use of better clustering
JoeRu Oct 28, 2025
57a5234
adapt test to new constants
JoeRu Oct 31, 2025
99c09ff
Update ImmichFrame.Core.Tests/Logic/Pool/AllAssetsPoolTests.cs
JoeRu Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ImmichFrame.Core.Tests/Logic/Pool/AlbumAssetsPoolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ private class TestableAlbumAssetsPool(IApiCache apiCache, ImmichApi immichApi, I
public void Setup()
{
_mockApiCache = new Mock<IApiCache>();
_mockImmichApi = new Mock<ImmichApi>("", null);
_mockImmichApi = new Mock<ImmichApi>("", null!);
_mockAccountSettings = new Mock<IAccountSettings>();
_albumAssetsPool = new TestableAlbumAssetsPool(_mockApiCache.Object, _mockImmichApi.Object, _mockAccountSettings.Object);

Expand Down
2 changes: 1 addition & 1 deletion ImmichFrame.Core.Tests/Logic/Pool/AllAssetsPoolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class AllAssetsPoolTests
public void Setup()
{
_mockApiCache = new Mock<IApiCache>();
_mockImmichApi = new Mock<ImmichApi>(null, null);
_mockImmichApi = new Mock<ImmichApi>(null!, null!);
Comment thread
JoeRu marked this conversation as resolved.
Outdated
_mockAccountSettings = new Mock<IAccountSettings>();
_allAssetsPool = new AllAssetsPool(_mockApiCache.Object, _mockImmichApi.Object, _mockAccountSettings.Object);

Expand Down
6 changes: 3 additions & 3 deletions ImmichFrame.Core.Tests/Logic/Pool/CachingApiAssetsPoolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class CachingApiAssetsPoolTests
// Concrete implementation for testing the abstract class
private class TestableCachingApiAssetsPool : CachingApiAssetsPool
{
public Func<Task<IEnumerable<AssetResponseDto>>> LoadAssetsFunc { get; set; }
public Func<Task<IEnumerable<AssetResponseDto>>>? LoadAssetsFunc { get; set; }

public TestableCachingApiAssetsPool(IApiCache apiCache, ImmichApi immichApi, IAccountSettings accountSettings)
: base(apiCache, immichApi, accountSettings)
Expand All @@ -39,7 +39,7 @@ protected override Task<IEnumerable<AssetResponseDto>> LoadAssets(CancellationTo
public void Setup()
{
_mockApiCache = new Mock<IApiCache>(); // ILogger, IOptions<AppSettings>
_mockImmichApi = new Mock<ImmichApi>(null, null); // ILogger, IHttpClientFactory, IOptions<AppSettings>
_mockImmichApi = new Mock<ImmichApi>("", null!); // ILogger, IHttpClientFactory, IOptions<AppSettings>
_mockAccountSettings = new Mock<IAccountSettings>();

_testPool = new TestableCachingApiAssetsPool(_mockApiCache.Object, _mockImmichApi.Object, _mockAccountSettings.Object);
Expand Down Expand Up @@ -133,7 +133,7 @@ public async Task AllAssets_UsesCache_LoadAssetsCalledOnce()
};

// Setup cache to really cache after the first call
IEnumerable<AssetResponseDto> cachedValue = null;
IEnumerable<AssetResponseDto>? cachedValue = null;
_mockApiCache.Setup(c => c.GetOrAddAsync(
It.IsAny<string>(),
It.IsAny<Func<Task<IEnumerable<AssetResponseDto>>>>()
Expand Down
Loading
Loading