Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable transition duration. Closes Feature requests #42 #45

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

3rob3
Copy link
Collaborator

@3rob3 3rob3 commented Mar 29, 2024

Closes #42
I could not get data binding to work for the CrossFade Duration so did it in Onloaded.
Removed "if(_appsettings == null)" because it will be caught now in Settings.cs parse/validate.

@3rob3 3rob3 requested a review from JW-CH March 29, 2024 18:13
@3rob3 3rob3 changed the title Closes Feature requests #42 configurable transition duration. Closes Feature requests #42 Mar 29, 2024
@@ -43,24 +44,21 @@ private async void OnLoaded(object? sender, RoutedEventArgs e)
ShowSplash();
_appSettings = Settings.CurrentSettings;
_viewModel.Settings = _appSettings;
//couldn't get data binding on CrossFade Duration to work, had to do this
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any more Info about this? Seems strange that this would not work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I fought with this for hours. Tried using different datatypes, tried converters, etc. with no luck. Seems like a limitation or bug in Avalonia. You can try, it won't even build if you try to set a binding on that property.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you raise the NotifyPropertyChanged event when setting the value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have been sick with covid since Friday afternoon. The property is TransitionDuration, it is a new member of the settings class just like all the other ones. The issue is not that it won't update the value, it just won't build at all when you set a binding on the CrossFade Duration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get well soon. I'll do some testing.

@3rob3 3rob3 merged commit be201a9 into main Apr 4, 2024
1 check passed
@3rob3 3rob3 deleted the Add-setting-and-support-for-transition-duration branch April 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature requests
2 participants