Refactoring and Settings error handling/validation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3rob3
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Everything else looks great, but I am a little confused my GetFilteredAssetIds. It seems like the intent is to combine using Memories/Albums/People (because they are ifs and not else ifs, and because you renamed OnlyMemories to ShowMemories)? Or are you just preparing for this possibility in the future?
There was a problem hiding this comment.
I was thinking about combining them. OnlyMemories was renamed to ShowMemories because I think it's odd to configure albums and then not showing them. For me, it seems more user-friendly if you combine all the options together, exactly how the config was set up.
|
Closes #28 |
|
Still todo:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.