Overlay anchor points #253
Conversation
| @@ -38,6 +38,18 @@ private Task<IEnumerable<Guid>> ExcludedAlbumAssets | |||
| } | |||
| } | |||
|
|
|||
| private Task<IEnumerable<Guid>>? _excludedPeopleAssets; | |||
There was a problem hiding this comment.
Why is this in this PR? If you create new branches, make sure you branch from main, not from another branch
There was a problem hiding this comment.
oops, my bad. I switched back to Main first but must not have pulled.
There was a problem hiding this comment.
Fixed it for you :) you have to rebase to this branch again.
| Webcalendars=https://calendar.mycalendar.com/basic.ics,webcal://calendar.mycalendar.com/basic.ics | ||
| WebCalendarPosition="top-0 right-0" |
There was a problem hiding this comment.
Defaults should be something like this: bottom-[0px] because bottom-0 is a preset and not every number is supported. For example, bottom-30 will not work and should be bottom-[30px] instead. bottom-[30%] is also allowed. Maybe we should document somewhere, that all tailwind syntax is valid. Also maybe this should not be explicitly named XYPosition and instead could be custom classes in general for WebCalendar but then it probably would make more sense just to have a separate CSS to overwrite this stuff. What do you think @3rob3
There was a problem hiding this comment.
Agree. I originally had a custom position class to convert "BottomLeft" to a CSS compatible string. It got very confusing and I had a lot of trouble getting it to work. Then I thought it would also be nice to adjust from 0 so did it like I did. I couldn't get any value other than 0 to work right so your explanation makes sense.
There was a problem hiding this comment.
https://tailwindcss.com/docs/top-right-bottom-left#arbitrary-values
For more information about the brackets
There was a problem hiding this comment.
Still doesn't work right, i think because it's parent is not relative? IDK
There was a problem hiding this comment.
hmm, i don't get it. When I put in any value other than zero it gets shoved all the way over to the left or top.
JW-CH
force-pushed
the
dev.3rob3.OverlayAnchorPoints
branch
from
211e371 to
86a75b4
Compare
Allow user to set anchor points for clock/weather, image info, and web calendar.
Closes #194, Closes #250