fix: rearranging and adding information #239
Conversation
|
question:
|
|
I personally think we should remove the settings.json. This was a carryover from the older apps. I prefer using ENV for config since it can easily be changed (and commented out) in Portainer and applied in just a few clicks. What do you think Jan @JW-CH ? |
|
This looks good to me. You good with it @JW-CH ? |
| To make it work you will need to uncomment `# - PATH/TO/ImageCacheFolder:/app/ImageCache` in your installation file. | ||
|
|
||
| > [!NOTE] | ||
| > If you enable the DownloadImages option to True without setting volumes for ImageCacheFolder it will cause an error! |
There was a problem hiding this comment.
Just to clarify for me, this does not cause an error if you don't set it in your volumes, right? This only throws an error if you uncomment it and do not change the value to a valid folder?
There was a problem hiding this comment.
When I tried to set the DownloadImages option to True it threw errors until I set a folder for DownloadImages ~ ImageCacheFolder.
This should not be the case. Do you have an error message? This is most likely a bug. The "ImageCache"-folder should be created in the application. I like the volume you made :)
When I tried to set the DownloadImages option to True it threw errors until I set a folder for DownloadImages ~ ImageCacheFolder.
In addition, I changed the order of the configuration files so that the options related to Cache will be in the appropriate order.