Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-shadow to app.css to improve readability #227

Closed

Conversation

iCanHazSkillz
Copy link
Contributor

Addresses suggestion made in request #198

@JW-CH
Copy link
Collaborator

JW-CH commented Dec 10, 2024

Thank you for your contribution. We are mostly using tailwind for our CSS. What are your thoughts on a custom CSS file that you can map to your container to edit/override and customize your immichFrame?

@iCanHazSkillz
Copy link
Contributor Author

iCanHazSkillz commented Dec 11, 2024

If you guys are completely against the idea of text shadows, then a custom CSS is definitely the next best option. I tried adding it to tailwind but couldn't get it to work. I'm really outside my comfort zone here.

Found a technical write-up on it but I'm exhausted and can't think straight right now. Might have a crack at it tomorrow.
https://www.hyperui.dev/blog/text-shadow-with-tailwindcss

@JW-CH JW-CH added the ImmichFrame_Web Label for the immichFrame webapp label Dec 11, 2024
@JW-CH
Copy link
Collaborator

JW-CH commented Dec 11, 2024

If you guys are completely against the idea of text shadows, then a custom CSS is definitely the next best option. I tried adding it to tailwind but couldn't get it to work. I'm really outside my comfort zone here.

Found a technical write-up on it but I'm exhausted and can't think straight right now. Might have a crack at it tomorrow. https://www.hyperui.dev/blog/text-shadow-with-tailwindcss

Thank you for the change and the resources. Do you mind adding it for the Clock too? I like the work :)

@iCanHazSkillz
Copy link
Contributor Author

Thank you! I went ahead and created 2 classes to accommodate shadows on both small and large text and applied it to the clock as well.

Let me know if there should be anything else added.

@JW-CH JW-CH self-requested a review December 13, 2024 07:37
@JW-CH
Copy link
Collaborator

JW-CH commented Dec 13, 2024

I think there happened something when pulling from main. Your code contains some of the new stuff but not everything and does not build anymore :P

@JW-CH
Copy link
Collaborator

JW-CH commented Dec 13, 2024

Replaced by #232

@JW-CH JW-CH closed this Dec 13, 2024
@3rob3
Copy link
Collaborator

3rob3 commented Dec 13, 2024

this looks really nice, thanks! A lot easier to see/read now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImmichFrame_Web Label for the immichFrame webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants