fix: avoid invalid label/button nesting in switch#571
Merged
Conversation
Contributor
|
📖 Preview of ui.immich.app deployed to ui.pr-571.dev.immich.app |
Member
|
Thanks! And welcome back! 😁 |
jrasm91
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nesting this switch inside a
<label>is invalid HTML because bits-ui renders the switch internally as a button, and a label shouldn’t wrap an interactive element. In Firefox, clicking the label can either do nothing or behave unpredictably by toggling adjacent switches.The fix is to render the label/description alongside Switch.Root instead of wrapping it. I tested this in Immich Web, but I’m not sure whether this component is used elsewhere.