Skip to content

fix: cursor-not-allowed on disabled button #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrasm91 merged 2 commits into from
Feb 3, 2026
+19 −19
Merged

fix: cursor-not-allowed on disabled button #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
838ecb5
fix: cursor-not-allowed on disabled button
meesfrensel Feb 1, 2026
ba93137
add not-disabled to hover style
meesfrensel Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions packages/ui/src/lib/internal/Button.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
base: 'flex items-center justify-center gap-1 rounded-md text-sm font-medium outline-offset-2 transition-colors focus-visible:outline-2',
variants: {
disabled: {
true: 'disabled:pointer-events-none disabled:opacity-50 aria-disabled:opacity-50',
true: 'cursor-not-allowed disabled:opacity-50 aria-disabled:opacity-50',
false: 'cursor-pointer',
},
shape: styleVariants.shape,
Expand Down Expand Up @@ -80,20 +80,20 @@
filledColor: styleVariants.filledColor,
filledColorHover: styleVariants.filledColorHover,
outlineColor: {
primary: 'border-primary bg-primary/10 text-primary hover:bg-primary/20 border',
secondary: 'border-dark bg-light-100 text-dark hover:bg-light-200 border',
success: 'border-success bg-success/10 text-success hover:bg-success/20 border',
danger: 'border-danger bg-danger/10 text-danger hover:bg-danger/20 border',
warning: 'border-warning bg-warning/10 text-warning hover:bg-warning/20 border',
info: 'border-info bg-info/10 text-info hover:bg-info/20 border',
primary: 'border-primary bg-primary/10 text-primary not-disabled:hover:bg-primary/20 border',
secondary: 'border-dark bg-light-100 text-dark not-disabled:hover:bg-light-200 border',
success: 'border-success bg-success/10 text-success not-disabled:hover:bg-success/20 border',
danger: 'border-danger bg-danger/10 text-danger not-disabled:hover:bg-danger/20 border',
warning: 'border-warning bg-warning/10 text-warning not-disabled:hover:bg-warning/20 border',
info: 'border-info bg-info/10 text-info not-disabled:hover:bg-info/20 border',
},
ghostColor: {
primary: 'text-primary hover:bg-primary-50',
secondary: 'text-dark hover:bg-light-100',
success: 'text-success hover:bg-success-50',
danger: 'text-danger hover:bg-danger-50',
warning: 'text-warning hover:bg-warning-50',
info: 'text-info hover:bg-info-50',
primary: 'text-primary not-disabled:hover:bg-primary-50',
secondary: 'text-dark not-disabled:hover:bg-light-100',
success: 'text-success not-disabled:hover:bg-success-50',
danger: 'text-danger not-disabled:hover:bg-danger-50',
warning: 'text-warning not-disabled:hover:bg-warning-50',
info: 'text-info not-disabled:hover:bg-info-50',
},
},
});
Expand Down
12 changes: 6 additions & 6 deletions packages/ui/src/lib/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,12 @@ export const styleVariants = {
},

filledColorHover: {
primary: 'hover:bg-primary/80',
secondary: 'hover:bg-dark/80',
success: 'hover:bg-success/80',
danger: 'hover:bg-danger/80',
warning: 'hover:bg-warning/80',
info: 'hover:bg-info/80',
primary: 'not-disabled:hover:bg-primary/80',
secondary: 'not-disabled:hover:bg-dark/80',
success: 'not-disabled:hover:bg-success/80',
danger: 'not-disabled:hover:bg-danger/80',
warning: 'not-disabled:hover:bg-warning/80',
info: 'not-disabled:hover:bg-info/80',
},

textSize: {
Expand Down
Loading