feat(web): update logo #7798
Merged
feat(web): update logo #7798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
538be2d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://516f226b.immich.pages.dev |
| Branch Preview URL: | https://feat-web-new-logo.immich.pages.dev |
|
Does web also include the documentation site? |
No, docs and mobile will be separate PRs :) |
web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte
Show resolved
Hide resolved
jrasm91
reviewed
Mar 11, 2024
| <section id="dashboard-navbar" class="fixed z-[900] h-[var(--navbar-height)] w-screen text-sm"> | ||
| <SkipLink>Skip to content</SkipLink> | ||
| <div | ||
| class="grid h-full grid-cols-[theme(spacing.18)_auto] items-center border-b bg-immich-bg py-2 dark:border-b-immich-dark-gray dark:bg-immich-dark-bg md:grid-cols-[theme(spacing.64)_auto]" | ||
| > | ||
| <a data-sveltekit-preload-data="hover" class="ml-4" href={AppRoute.PHOTOS}> | ||
| <ImmichLogo width="55%" /> | ||
| <ImmichLogo width="55%" noText={innerWidth < 770} /> |
There was a problem hiding this comment.
can we not leverage the tailwind breakpoints and classes here?
There was a problem hiding this comment.
I tried to think of a way but couldn't find one since you have to toggle the prop of the component.
There was a problem hiding this comment.
We could have two elements I guess (with different classes and one has noText and one does not). Idk if that is any better though.
There was a problem hiding this comment.
yeah, I'd like to keep it in a single component
34 tasks
jrasm91
approved these changes
Mar 12, 2024
danieldietzler
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo