fix(server): regular version check #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dt.diffNow()` equals `dt.diff(DateTime.now())`, so it returns a negative number when `dt` is in the past (which it always is in this case). Therefore we could only get over the condition during startup (when `this.releaseVersionCheckedAt` isn't set yet), effectively breaking update notifications while the server is running.
danieldietzler
approved these changes
Mar 4, 2024
|
Thanks for fixing this, but I noticed you didn't add any unit tests. Would that be something you would be able to do in a follow up PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dt.diffNow()equalsdt.diff(DateTime.now()), so it returns a negative number whendtis in the past (which it always is in this case).Therefore we could only get over the condition during startup (when
this.releaseVersionCheckedAtisn't set yet), effectively breaking update notifications while the server is running.There are different ways to write this, e.g.
I prefer the first one because it feels most readable. Second is basically reversing the timestamps, third does the same (assuming that time only moves forward). I don't like the fourth way, hard to read from my point of view.