chore(server): eslint await-thenable

[etnoy]

Looking for feedback on this before modifying other packages.

I had an unneeded await in my code and found an eslint rule to prevent it. It also found three other parts where it could have been used incorrectly

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	d66a581
Status:	✅  Deploy successful!
Preview URL:	https://84dc9f44.immich.pages.dev
Branch Preview URL:	https://chore-eslint-await-thenable.immich.pages.dev

View logs

[jrasm91]

LGTM. maybe we can look at making a parent config that these all extend so they can all have the same core set of rules.

[etnoy]

LGTM. maybe we can look at making a parent config that these all extend so they can all have the same core set of rules.

Seems like it shouldn't be too hard. https://turbo.build/repo/docs/handbook/linting/eslint

[benmccann]

There are a few other rules to improve promise handling that I just turned on in the web project and which you might find to be useful here: https://github.com/immich-app/immich/pull/7382/files#diff-c1f89ef5e816f54437b1a48e36db79213d698329e9bbafd4c84a81506d8f197fR52

[etnoy]

There are a few other rules to improve promise handling that I just turned on in the web project and which you might find to be useful here: https://github.com/immich-app/immich/pull/7382/files#diff-c1f89ef5e816f54437b1a48e36db79213d698329e9bbafd4c84a81506d8f197fR52

Thanks, Ben! I added those rules and made the corresponding modifications :)