chore: remove watcher polling option

[etnoy]

Polling for the library watcher only seems to bring problems. If users want to rescan libraries automatically we should probably have them use the cron feature instead.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	aa54bac
Status:	✅  Deploy successful!
Preview URL:	https://5296fbe8.immich.pages.dev
Branch Preview URL:	https://chore-remove-watch-polling.immich.pages.dev

View logs

[jrasm91]

We should maybe include a migration to delete the option from the database

[etnoy]

We should maybe include a migration to delete the option from the database

Totally forgot about that

[danieldietzler]

Nice! Seeing such a diff always makes me happy :)
If most people won't use it anyways I think removing this makes sense.

[etnoy]

We should maybe include a migration to delete the option from the database

Is there an easy way to create a migration for a config change? Typeorm doesn't see any changes

[alextran1502]

This is a breaking chance because we removed a feature. There is no breaking changes on database level or deployment method, correct?

[jrasm91]

There are no schema changes, you just need to write a migration that will delete the key if it has been set. Take a look at:

server/src/infra/migrations/1674263302005-RemoveVideoCodecConfigOption.ts

You can generate an empty migration with npm run typeorm:migrations:create

[etnoy]

This is a breaking chance because we removed a feature. There is no breaking changes on database level or deployment method, correct?

Yes, we are removing an fature that was previously available but mostly seems to be causing problems. Those who wish to use a polling-type library refresh should use the cron feature instead. The library watcher is still available for those who don't mount their external libraries from a network drive.

[figadore]

Polling for the library watcher only seems to bring problems.

Can you link to the issue(s) where these problems were detailed?