-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): rkmpp hardware decoding scaling #7472
Conversation
Deploying with
|
Latest commit: |
8a315e4
|
Status: | ✅ Deploy successful! |
Preview URL: | https://241eaaeb.immich.pages.dev |
Branch Preview URL: | https://feat-rkmpp-hardware-decoding.immich.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test that it works with an HDR video?
Any freely available test video? |
It just needs to have the tone-mapping stuff in the command and transcode without any error logs. Any random YT video with HDR will work. |
For test videos I use these samples from Kodi, there are also links to external sources with even more videos |
I've disable hardware decoding/scaling for HDR videos (encoding still works). I'll try to get hardware decoding and hardware tonemapping via OpenCL to work in another PR. the RK3588 SOC has hardware support for HDR tonemapping... I just don't know yet whether this ffmpeg build can use it and if so, how. |
Sounds good. Jellyfin uses libplacebo and we use their FFmpeg build, so it should be possible. I just haven't been able to get the right command to make it work. |
enables full hardware transcoding via RKMPP on RK3588 platform: decode, scale filter, encode
transcode speed: 20x realtime for hevc, 27x realtime for h264 🚀