feat(server): enable exiftool largefilesupport in metadata repo #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvdnabee
changed the title
|
Thanks! Since this is an option that is not enabled in exiftool by default, presumably there are some considerations around setting it. I can't find much detail about what those are though, do you have any insight into that? |
|
Hello @bo0tzz, I asked about that in the exiftool-Forum. Phil (the author of the tool) answered that this can cause a runtime error on older systems (which are not common any more). |
mertalev
reviewed
Apr 1, 2024
|
|
||
| async init(): Promise<void> { | ||
| if (!this.subscription) { | ||
| this.subscription = this.configCore.config$.subscribe(() => this.init()); |
There was a problem hiding this comment.
This creates a new exiftool instance with the updated setting, but it wouldn't close the previous one.
|
See newer PR at #9894 which drops the system config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in process
Fixes immich issue #4349
Related exiftool-vendored.js comment