-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): add an option to change the date formats #7174
Conversation
Maybe put it under "Date & Time" section instead of Appearance? |
Browsers may not support all locales, have you tested what happens in that case? We also use |
web/src/lib/components/admin-page/settings/setting-combobox.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/admin-page/settings/setting-combobox.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/admin-page/settings/setting-combobox.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/user-settings-page/appearance-settings.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/user-settings-page/appearance-settings.svelte
Outdated
Show resolved
Hide resolved
Deploying with
|
Latest commit: |
c039ebc
|
Status: | ✅ Deploy successful! |
Preview URL: | https://635cf9d9.immich.pages.dev |
Branch Preview URL: | https://feat-user-locale.immich.pages.dev |
What dateTime section are you speaking about ? Do you want me to create a new section or rename it from "Local" to "Date and Time"? |
fc3b359
to
c2282fc
Compare
Yes, I am thinking of a new accordion dedicated to date-time settings. |
Hmm, I don't know if it's a good idea to add a new one, there are already a lot. Maybe rename “Appearance” to “Customization”? |
web/src/lib/components/admin-page/settings/setting-combobox.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/user-settings-page/appearance-settings.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/admin-page/settings/storage-template/supported-datetime-panel.svelte
Outdated
Show resolved
Hide resolved
Co-authored-by: Michel Heusschen <[email protected]>
d05328c
to
524223f
Compare
I moved locales to a javascript object instead, so it has type information. |
Add an option to change the date formats.
All locales are stored in a json file. This seems to be the only way to get the list (see https://github.com/nextcloud/server/blob/c7ef27d066aea2406c8009bd1a49888d1610b889/resources/locales.json). Sorry if I forgot any.
Screenshots
2024-02-18.18-00-04.mp4
(my default locale is
en-US
)