feat(web): add skip link to top navigation #7091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-basten
commented
Feb 13, 2024
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| <section | |||
| id="sidebar" | |||
| tabindex="-1" | |||
There was a problem hiding this comment.
This pulls the sidebar container out of the tab order, so the next tab stop after <main> is the first sidebar button.
|
nvm I see it |
|
What is the problem you are trying to solve here? |
|
@alextran1502 this is for users who use screen readers and such, to streamline their navigation. |
|
@alextran1502 I think the WCAG accessibility spec explains it better than I can - the first 2 paragraphs have a good explanation. https://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-skip.html |
danieldietzler
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an invisible skip link button in the top navigation bar that appears when focused for easier keyboard navigation.
Screenshots
DarkLight
Checklist