-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server,web) Semantic import path validation #7076
Conversation
Deploying with
|
Latest commit: |
5b93c06
|
Status: | ✅ Deploy successful! |
Preview URL: | https://87ba4580.immich.pages.dev |
Branch Preview URL: | https://fix-validate-import-path.immich.pages.dev |
Maybe the warning can go by the path itself not the action buttons |
Yes, the front end stuff needs more work, I'm currently focusing on the backend first |
…validate-import-path
…validate-import-path
…validate-import-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at all of this, is there any reason these checks can't be run inside of the library create and update methods? It is a bit confusing if you can create an invalid external library and have to validate it independently.
IMO running the checks separately from changes makes sense. The library can break for external reasons (eg the mount goes offline), in which case having a check that immediately shows that would be nice. |
Sure, but that should be in addition to doing the check at time of creation imo. |
…validate-import-path
…validate-import-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
…validate-import-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…validate-import-path
Check if import paths are valid and warn user if they aren't.
This should help some users to prevent simple mistakes I've seen several times in discord
When scanning the library, import paths that do not pass validation are ignored
We also pop up a notification when the validation button is clicked
![image](https://private-user-images.githubusercontent.com/135728/306091193-a6257a3b-2fc2-447a-b541-7970c8a9d541.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNjcwMjYsIm5iZiI6MTczOTM2NjcyNiwicGF0aCI6Ii8xMzU3MjgvMzA2MDkxMTkzLWE2MjU3YTNiLTJmYzItNDQ3YS1iNTQxLTc5NzBjOGE5ZDU0MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQxMzI1MjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iMDBjNzBjOGNlMTZlYzQ0ODBkMWM4M2Y3MGE1ZWU1MWU5MTU4OWNmNzcwYjFhOWZjMTQ2NzJmZTQyNjg1MThjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.xp_9i2fhLgfg0DzlAQ1emJSw8iSfyKOMUESFpimK2K8)