Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: library watching #7071

Merged
merged 1 commit into from
Feb 13, 2024
Merged

refactor: library watching #7071

merged 1 commit into from
Feb 13, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Feb 13, 2024

Make testing the library service easier and decouple with chokidar types.

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 999773e
Status: ✅  Deploy successful!
Preview URL: https://1c12db16.immich.pages.dev
Branch Preview URL: https://refactor-library-watching.immich.pages.dev

View logs

Copy link
Contributor

@etnoy etnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach, makes things clearer and separates duties

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice

Comment on lines +117 to +118
let _resolve: () => void;
const ready$ = new Promise<void>((resolve) => (_resolve = resolve));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@jrasm91 jrasm91 merged commit b648025 into main Feb 13, 2024
25 checks passed
@jrasm91 jrasm91 deleted the refactor/library-watching branch February 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants