Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mobile): Put the real delete button before other delete variants #6895

Merged

Conversation

lukaszwawrzyk
Copy link
Contributor

@lukaszwawrzyk lukaszwawrzyk commented Feb 3, 2024

Hi!
After recent update that split the trash action into 3 buttons (#4505) the most frequently used button - actual delete from the phone and remote - requires scrolling to access.
I moved it before its 2 cousins so that it is visible right away.
I believe that this is the primary delete action so it should be first.

@shenlong-tanwen
Copy link
Member

Thank you for the PR. But more than being primary, it is the most destructive of the three as well, right after the remove local file. So wouldn't it make sense that it takes a bit more effort to actually perform this operation?

@lukaszwawrzyk
Copy link
Contributor Author

I am not sure how other people use Immich, but for me, this is the most important action that I need.

  • delete from device -> this is just to save space on device; there were discussions to move it to some menu, like in google photos, "free up the space"
  • delete from immich but keep on device -> I don't really see a use case, I want my photos in sync with the server

I want to just be able to delete a photo, not every photo is perfect, some screenshots/photos are just temporary. I need to clean my gallery on regular basis and I need to do it through Immich.

The action removes file from device and it is moved to trash on the server, so it is easily recoverable + there is a warning dialog. I think that one protection mechanism is enough (I wouldn't additionally hide it, so that it would need an extra swipe).

Also note that in the asset view, we do see the real delete action. Similarly in google photos, this is the only action available in both asset and select views.

Delete action is just a common thing to do, with trash it can be easily undone and for me and immich users that I know it is annoying to go through this extra step.

@alextran1502 alextran1502 merged commit e9f3360 into immich-app:main Feb 14, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants