fix(server): do not process faces of deleted assets #6710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
754a03e
|
| Status: | ⚡️ Build in progress... |
mertalev
changed the title
|
It sounds like this is probably caused by trashed assets. So we should probably just make sure we ignore deleted assets instead. |
|
That was the original PR, but then I noticed that there actually is a |
|
Although I'm not sure why a row still exists if |
|
Right, I think it would be good to reproduce the actual issue before making a change like this. I have seen owner being null before, specifically when something references a relation that has been deleted. |
mertalev
force-pushed
the
fix/server-ignore-deleted
branch
from
21bed63 to
ff7c6eb
Compare
mertalev
changed the title
jrasm91
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When querying for faces during recognition, a face from an asset that was deleted after queueing will throw an error. While TypeORM has a default filter for deleted entities, it still returns an entity if it has deleted relations. The quick fix is to check the asset relation. Moving forward, it may be good to switch to inner joins for relations. This is beyond the scope of this fix as it involves switching to query builders, complicates custom selects, etc.
Fixes #6709