chore: remove no-op patch #6649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
reviewed
Jan 26, 2024
There was a problem hiding this comment.
That looks to be true, however, we can actually remove the templates/typescript directory, all apiInner* files, and update the bash script to not download the file in the first place (or use the template directory). Do you mind removing all of those changes as well?
|
Excellent! That really simplified things. I've made the suggested changes |
jrasm91
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I remove this patch, the same output is generated. The presence of this patch prevents an upgrade of the OpenAPI Generator. There are other issues preventing an upgrade as well, but this would address one of them at least